8000 [Form] [Util] [PropertyPath] Added __call method to property path by piotrpasich · Pull Request #6413 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Form] [Util] [PropertyPath] Added __call method to property path #6413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

piotrpasich
Copy link

Bug fix: no
Feature addition: yes
Backwards compatibility break: yes (it might be a problem when class has __call and __get and __set method)
Symfony2 tests pass: yes
Fixes the following tickets: no ticket
Todo: no todos
License of the code: MIT
Documentation PR: The situation with magical method is not probably described in documentation.

@webmozart
Copy link
Contributor

Closing this in favor of #7263.

@webmozart webmozart closed this Apr 18, 2013
fabpot added a commit that referenced this pull request Apr 25, 2013
This PR was merged into the master branch.

Discussion
----------

[PropertyAccess] add support for magic call

Hi,

I add support for magic call with the `PropertyAccess`

the is basic implementation, if no `getter`, `isser`, or `hasser` or `_get` is found and there is `__call` then the PropertyAccess call the getter

the same for setter.

This functionality is disable by default

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | seems OK (failure/errors are the same on master)
| Fixed tickets | #4683, #6413, #5309
| License       | MIT
| Doc PR        | symfony/symfony-docs#2472

- [x] submit changes to the documentation

@bschussek is this ok ?

Commits
-------

a785baa [PropertyAccess] add support for magic call, related to #4683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0