[Console] fixed progress bar jumping for windows & unix env #6266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good implementation but could you please check http://symfony.com/doc/current/contributing/code/standards.html |
fabpot
added a commit
that referenced
this pull request
Dec 11, 2012
This PR was merged into the master branch. Commits ------- ea74610 jumping progress bar fix for windows & unix 6a0ee27 [Console] fixed progress bar jumping Discussion ---------- [Console] fixed progress bar jumping for windows & unix env Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: - Todo: - License of the code: MIT Documentation PR: - --------------------------------------------------------------------------- by pborreli at 2012-12-11T13:58:25Z Good implementation but could you please check http://symfony.com/doc/current/contributing/code/standards.html
|
This implementation is broken IMO: it does not track the length of the last message written (which needs to be overwritten) but of the last message overwriting another message (which has no reason to be the message you are overwriting now) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -
License of the code: MIT
Documentation PR: -