jumping progress bar fix for windows & unix

Robert Queck · Robert Queck · commit ea74610723f7 · 2012-12-11T14:31:22.000+01:00
diff --git a/src/Symfony/Component/Console/Helper/ProgressHelper.php b/src/Symfony/Component/Console/Helper/ProgressHelper.php
@@ -36,6 +36,7 @@ class ProgressHelper extends Helper
     private $format       = null;
     private $redrawFreq   = 1;
 
+    private $lastMessagesLength;
     private $barCharOriginal;
 
     /**
@@ -384,8 +385,13 @@ private function humaneTime($secs)
     private function overwrite(OutputInterface $output, $messages)
     {
         $output->write("\x0D"); // carriage return
-        $output->write("\x1B\x5B\x4B"); // clear line
+        if($this->lastMessagesLength!==null){
+            $output->write(str_repeat("\x20", $this->lastMessagesLength)); //clear the line with the length of the last message
+            $output->write("\x0D"); // carriage return
+        }
         $output->write($messages);
+
+        $this->lastMessagesLength=strlen($messages);
     }
 
     /**
diff --git a/src/Symfony/Component/Console/Tests/Helper/ProgressHelperTest.php b/src/Symfony/Component/Console/Tests/Helper/ProgressHelperTest.php
@@ -80,8 +80,18 @@ protected function getOutputStream()
         return new StreamOutput(fopen('php://memory', 'r+', false));
     }
 
+    protected $lastMessagesLength;
+
     protected function generateOutput($expected)
     {
-        return "\x0D\x1B\x5B\x4B".$expected;
+        $expectedout = $expected;
+
+        if($this->lastMessagesLength!==null){
+            $expectedout=str_repeat("\x20", $this->lastMessagesLength)."\x0D".$expected;
+        }
+
+        $this->lastMessagesLength=strlen($expected);
+
+        return "\x0D".$expectedout;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -80,8 +80,18 @@ protected function getOutputStream()`
`80`	`80`	`return new StreamOutput(fopen('php://memory', 'r+', false));`
`81`	`81`	`}`
`82`	`82`
	`83`	`+ protected $lastMessagesLength;`
	`84`	`+`
`83`	`85`	`protected function generateOutput($expected)`
`84`	`86`	`{`
`85`		`- return "\x0D\x1B\x5B\x4B".$expected;`
	`87`	`+ $expectedout = $expected;`
	`88`	`+`
	`89`	`+ if($this->lastMessagesLength!==null){`
	`90`	`+ $expectedout=str_repeat("\x20", $this->lastMessagesLength)."\x0D".$expected;`
	`91`	`+ }`
	`92`	`+`
	`93`	`+ $this->lastMessagesLength=strlen($expected);`
	`94`	`+`
	`95`	`+ return "\x0D".$expectedout;`
`86`	`96`	`}`
`87`	`97`	`}`