8000 [VarDumper] Don't make `CurlCasterTest` response status dependant by alexandre-daubois · Pull Request #59850 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[VarDumper] Don't make CurlCasterTest response status dependant #59850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2025
Merged

[VarDumper] Don't make CurlCasterTest response status dependant #59850

merged 1 commit into from
Feb 25, 2025

Conversation

alexandre-daubois
Copy link
Member
Q A
Branch? 7.3
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

This test sometimes fail because http://example.com/ returns a status code 400 instead of 200, making the CI red randomly. I think this test success should not depend on the status code, the goal is only to check if the data is properly formatted.

@carsonbot carsonbot added this to the 7.3 milestone Feb 24, 2025
@welcoMattic
Copy link
Member

Thank you @alexandre-daubois.

@welcoMattic welcoMattic merged commit c715827 into symfony:7.3 Feb 25, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

@welcoMattic welcoMattic welcoMattic approved these changes

@mtarld mtarld mtarld approved these changes

Assignees
No one assigned
Labels
Status: Reviewed VarDumper
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.
5 participants
@alexandre-daubois @welcoMattic @stof @mtarld @carsonbot
0