minor #59850 [VarDumper] Don't make CurlCasterTest response status dependant (alexandre-daubois)

welcoMattic · welcoMattic · commit c71582781e22 · 2025-02-25T14:12:44.000+01:00
This PR was merged into the 7.3 branch. Discussion ---------- [VarDumper] Don't make `CurlCasterTest` response status dependant | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT This test sometimes fail because http://example.com/ returns a status code 400 instead of 200, making the CI red randomly. I think this test success should not depend on the status code, the goal is only to check if the data is properly formatted. Commits ------- 83bce43 [VarDumper] Don't make `CurlCasterTest` response status dependant
diff --git a/src/Symfony/Component/VarDumper/Tests/Caster/CurlCasterTest.php b/src/Symfony/Component/VarDumper/Tests/Caster/CurlCasterTest.php
@@ -32,7 +32,8 @@ public function testCastCurl()
 CurlHandle {
   url: "http://example.com/"
   content_type: "text/html"
-  http_code: 200%A
+  http_code: %d
+%A
 }
 EODUMP, $ch);
     }

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,8 @@ public function testCastCurl()`
`32`	`32`	`CurlHandle {`
`33`	`33`	`url: "http://example.com/"`
`34`	`34`	`content_type: "text/html"`
`35`		`- http_code: 200%A`
	`35`	`+ http_code: %d`
	`36`	`+%A`
`36`	`37`	`}`
`37`	`38`	`EODUMP, $ch);`
`38`	`39`	`}`