8000 [Notifier] [Bluesky] Return the record CID as additional info by javiereguiluz · Pull Request #59789 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Notifier] [Bluesky] Return the record CID as additional info #59789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking 8000 “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2025
Merged

[Notifier] [Bluesky] Return the record CID as additional info #59789

merged 1 commit into from
Feb 18, 2025

Conversation

javiereguiluz
Copy link
Member
Q A
Branch? 7.3
Bug fix? no
New feature? yes
Deprecations? no
Issues -
License MIT

Some Bluesky API operations (like replies and quotes) require "strong references", which is the combination of the uri and the cid (See https://docs.bsky.app/docs/advanced-guides/posts#replies-quote-posts-and-embeds).

After the changes made in #59742, we should also return the cid as additional info.

@javiereguiluz javiereguiluz added this to the 7.3 milestone Feb 17, 2025
@carsonbot carsonbot changed the title [Notifier][Bluesky] Return the record CID as additional info [Notifier] [Bluesky] Return the record CID as additional info Feb 17, 2025
@fabpot
Copy link
Member
fabpot commented Feb 17, 2025

This should maybe be done in 7.2 as well (so that people that were using it already can still access it?).

@nicolas-grekas
Copy link
Member

This should maybe be done in 7.2 as well (so that people that were using it already can still access it?).

@fabpot the info array is supported since 7.3

@nicolas-grekas
Copy link
Member

the info array is supported since 7.3

low-deps failure highlight a missing bump in the deps of the bridge ;)

@nicolas-grekas
Copy link
Member

Thank you @javiereguiluz.

@nicolas-grekas nicolas-grekas merged commit 3ef4f4e into symfony:7.3 Feb 18, 2025
5 of 10 checks passed
@nicolas-grekas nicolas-grekas mentioned this pull request Feb 18, 2025
Closed
@javiereguiluz javiereguiluz deleted the bluesky_cid branch February 18, 2025 15:40
@fabpot fabpot mentioned this pull request May 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@alexandre-daubois alexandre-daubois alexandre-daubois approved these changes

Assignees
No one assigned
Labels
Feature Notifier Status: Reviewed
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.
6 participants
@javiereguiluz @fabpot @nicolas-grekas @OskarStark @alexandre-daubois @carsonbot
0