[Notifier] [BlueSky] Change the value returned as the message ID #59742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This snippet can be added to public function testUriIsSetAsMessageId()
{
$client = new MockHttpClient(function () {
return new JsonMockResponse([
'uri' => 'https://example.com',
'cid' => 'my_cid',
]);
});
$transport = self::createTransport($client);
$message = $transport->send(new ChatMessage('Hello!'));
$this->assertSame('https://example.com', $message->getMessageId());
} |
|
Alex, thanks a lot for creating the test for this 🙏 I only changed the values of the uri/cid to make them a bit more realistic because the BlueSky URI uses an uncommon format and it's better to test that too. Thanks. |
fabpot
approved these changes
Feb 10, 2025
alexandre-daubois
approved these changes
Feb 10, 2025
chalasr
reviewed
Feb 10, 2025
| @@ -5,6 +5,7 @@ CHANGELOG | |||
| --- | |||
|
|
|||
| * Add option to attach a media | |||
| * [BC Break] Change the returned message ID from record's 'cid' to 'uri' | |||
There was a problem hiding this comment.
Should be reverted as changelogs are auto-updated for bugfixes
There was a problem hiding this comment.
Only the main CHANGELOG. Here, we want to signify something unusual, I think it's fine.
There was a problem hiding this comment.
Fine for me as well, but I think it's worth noticing that we had similar discussions in the past and the conclusion was it's either a bugfix or a BC break, not both.
OskarStark
approved these changes
Feb 10, 2025
87f8c45 to
4121f68
Compare
|
Thank you @javiereguiluz. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 18, 2025
…al info (javiereguiluz) This PR was squashed before being merged into the 7.3 branch. Discussion ---------- [Notifier] [Bluesky] Return the record CID as additional info | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | - | License | MIT Some Bluesky API operations (like replies and quotes) require "strong references", which is the combination of the `uri` and the `cid` (See https://docs.bsky.app/docs/advanced-guides/posts#replies-quote-posts-and-embeds). After the changes made in #59742, we should also return the `cid` as additional info. Commits ------- 85a073e [Notifier] [Bluesky] Return the record CID as additional info
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some BlueSky API actions require both the
cidand theuri(see https://docs.bsky.app/docs/tutorials/like-repost) so we might re-add thecidto SentMessage'sinfoin Symfony 7.3.