8000 6.4 Missing translations for Italian (it) #59419 by eddya92 · Pull Request #59468 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

6.4 Missing translations for Italian (it) #59419 #59468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2025
Merged

6.4 Missing translations for Italian (it) #59419 #59468

merged 1 commit into from
Jan 11, 2025

Conversation

eddya92
Copy link
Contributor
@eddya92 eddya92 commented Jan 10, 2025 •
edited
Loading
Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Issues Fix #59419
License MIT

@carsonbot carsonbot added this to the 6.4 milestone Jan 10, 2025
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "7.3 for features / 6.4, 7.1, and 7.2 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

nicolas-grekas
nicolas-grekas reviewed Jan 10, 2025
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please also check unit 120 and remove the needs-review-translation attribute?

@eddya92
Copy link
Contributor Author
eddya92 commented Jan 10, 2025

Sorry for my mistakes, but this is my first time trying to contribute.
I have updated everything.

@nicolas-grekas
Copy link
Member

Thank you @eddya92.

@nicolas-grekas nicolas-grekas merged commit eea51e3 into symfony:6.4 Jan 11, 2025
8 checks passed
@eddya92
Copy link
Contributor Author
eddya92 commented Jan 11, 2025

Hey @nicolas-grekas , I’m really happy that my pull request got accepted! I was wondering—how many contributions (or pushes) are needed to be officially listed as a contributor?

@nicolas-grekas
Copy link
Member

Just one is enough :)
We update the list every month when we make a new release. Please also ensure that you have a Symfony Connect account with the same email as the email you're using in git commits.

@eddya92
Copy link
Contributor Author
eddya92 commented Apr 18, 2025

Hi @nicolas-grekas,

How can I see my name among the contributors?

@fabpot
Copy link
Member
fabpot commented Apr 21, 2025

Hi @nicolas-grekas,

How can I see my name among the contributors?

It will appear here: https://github.com/symfony/symfony/blob/6.4/CONTRIBUTORS.md (but as Nicolas mentioned, this file is updated once a month when new releases are published).

@chalasr
Copy link
Member
chalasr commented Apr 21, 2025

I believe you’re already mentioned in this file and on symfony.com contributors list as « Eddy »

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

Assignees
No one assigned
Labels
Bug Deprecation Feature Status: Needs Review
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
5 participants
@eddya92 @carsonbot @nicolas-grekas @fabpot @chalasr
0