[Validator] Checked Turkish validators translations and confirmed #59440
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
| @@ -468,7 +468,7 @@ | |||
| </trans-unit> | |||
| <trans-unit id="120"> | |||
| <source>This value is not a valid slug.</source> | |||
| <target state="needs-review-translation">Bu değer geçerli bir slug değildir.</target> | |||
| <target>Bu değer geçerli bir adres adı değildir.</target> | |||
There was a problem hiding this comment.
shouldn't we keep the word "slug" somewhere? "address name" is a different concept i think, slug is more specific
There was a problem hiding this comment.
"slug" doesnt mean anything in Turkish.. i guess its more like a technical term and although its understandable for developers, im not sure if a normal turkish user can understand it easily.
the best term i found for "slug" is "kısa adres adı" which means "short address name". what do you think?
There was a problem hiding this comment.
it is a technical term indeed, I'm not sure it makes sense to translate it (no other language does it, for now at least). Maybe it should be enclosed in double quotes (or a Turkish equivalent)?
There was a problem hiding this comment.
can another language speakers understand "slug"? im thinking out loud, if i wasn't a developer i would not understand what does "slug" mean
There was a problem hiding this comment.
yet enclosing in double quotes makes sense..
00fbefb to
438b58c
Compare
|
Thank you @h22k. |
Thank you! That was my first contribution, you made my day! |
Checked the Turkish validators translations.
I removed comma from trans-unit=51 because in Turkish we GENERALLY dont use comma just before conjunctions.
In addition, since the word slug is not understandable for Turkish speakers and there is no exact translation, I replaced slug word with the a Turkish word (Alan adı) which is more understandable.