8000 Improve Validator & Security Turkish translations by taubsix3 · Pull Request #58534 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Improve Validator & Security Turkish translations #58534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2024
Merged

Improve Validator & Security Turkish translations #58534

merged 1 commit into from
Oct 23, 2024

Conversation

taubsix3
Copy link
Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Issues Fix #53781
License MIT

Added and improved missing Validator & Security Turkish translations.

@taubsix3 taubsix3 requested a review from chalasr as a code owner October 10, 2024 17:28
@carsonbot carsonbot added this to the 7.2 milestone Oct 10, 2024
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.2" but it seems your PR description refers to branch "5.4".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@taubsix3 taubsix3 changed the base branch from 7.2 to 5.4 October 10, 2024 17:31
@xabbuh xabbuh modified the milestones: 7.2, 5.4 Oct 10, 2024
@nicolas-grekas nicolas-grekas changed the title Fix 53781 Improve Validator & Security Turkish translations Oct 23, 2024
@nicolas-grekas
Copy link
Member

Thank you @taubsix3.

@nicolas-grekas nicolas-grekas merged commit f42d2ce into symfony:5.4 Oct 23, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

Missing translations for Turkish (tr)
4 participants
@taubsix3 @carsonbot @nicolas-grekas @xabbuh
0