8000 Remove a few unnecessary full qualifier by alexandre-daubois · Pull Request #58430 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Remove a few unnecessary full qualifier #58430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexandre-daubois
Copy link
Member
Q A
Branch? 7.2
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

Remove full qualifier in places there are not present usually in the code base: mocks, already imported classes, expected exceptions.

@@ -1122,7 +1122,7 @@ public function testAddObjectResource()

$this->assertCount(1, $resources);

/* @var $resource \Symfony\Component\Config\Resource\FileResource */
/* @var $resource FileResource */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/* @var $resource FileResource */
/* @var FileResource $resource */

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, thanks!

@alexandre-daubois alexandre-daubois force-pushed the unecessary-full-qualifier branch from 7e520bc to 1543068 Compare October 2, 2024 06:33
@nicolas-grekas
Copy link
Member

Thank you @alexandre-daubois.

@nicolas-grekas nicolas-grekas merged commit a6b38b4 into symfony:7.2 Oct 3, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0