10000 Remove a few unnecessary full qualifier by alexandre-daubois · Pull Request #58430 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Remove a few unnecessary full qualifier #58430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
10000 Expand Up @@ -253,7 +253,7 @@ public function testKeyEncoding()
$pool = $this->createCachePool(0, null, $namespace);

/**
* Choose a key that is below {@see \Symfony\Component\Cache\Adapter\MemcachedAdapter::$maxIdLength} so that
* Choose a key that is below {@see MemcachedAdapter::$maxIdLength} so that
* {@see \Symfony\Component\Cache\Traits\AbstractTrait::getId()} does not shorten the key but choose special
* characters that would be encoded and therefore increase the key length over the Memcached limit.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
namespace Symfony\Component\Console\Tests\Helper;

use PHPUnit\Framework\TestCase;
use Symfony\Component\Console\Exception\InvalidArgumentException;
use Symfony\Component\Console\Helper\TableCellStyle;

class TableCellStyleTest extends TestCase
Expand All @@ -21,7 +22,8 @@ public function testCreateTableCellStyle()
$tableCellStyle = new TableCellStyle(['fg' => 'red']);
$this->assertEquals('red', $tableCellStyle->getOptions()['fg']);

$this->expectException(\Symfony\Component\Console\Exception\InvalidArgumentException::class);
$this->expectException(InvalidArgumentException::class);

new TableCellStyle(['wrong_key' => null]);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -1122,7 +1122,7 @@ public function testAddObjectResource()

$this->assertCount(1, $resources);

/* @var $resource \Symfony\Component\Config\Resource\FileResource */
/* @var FileResource $resource */
$resource = end($resources);

$this->assertInstanceOf(FileResource::class, $resource);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

namespace Symfony\Component\Messenger\Bridge\Doctrine\Tests\Transport;

use Doctrine\DBAL\Configuration;
use Doctrine\DBAL\Connection as DBALConnection;
use Doctrine\DBAL\Exception as DBALException;
use Doctrine\DBAL\Platforms\AbstractPlatform;
Expand Down Expand Up @@ -308,7 +309,7 @@ private function getDBALConnectionMock()
$platform->method('getWriteLockSQL')->willReturn('FOR UPDATE SKIP LOCKED');
}

$configuration = $this->createMock(\Doctrine\DBAL\Configuration::class);
$configuration = $this->createMock(Configuration::class);
$driverConnection->method('getDatabasePlatform')->willReturn($platform);
$driverConnection->method('getConfiguration')->willReturn($configuration);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

namespace Symfony\Component\Messenger\Bridge\Doctrine\Tests\Transport;

use Doctrine\DBAL\Connection;
use Doctrine\DBAL\Driver\Result as DriverResult;
use Doctrine\DBAL\Platforms\PostgreSQLPlatform;
use Doctrine\DBAL\Query\QueryBuilder;
Expand All @@ -29,7 +30,7 @@ public function testSerialize()
$this->expectException(\BadMethodCallException::class);
$this->expectExceptionMessage('Cannot serialize '.PostgreSqlConnection::class);

$driverConnection = $this->createMock(\Doctrine\DBAL\Connection::class);
$driverConnection = $this->createMock(Connection::class);
$driverConnection->method('executeStatement')->willReturn(1);

$connection = new PostgreSqlConnection([], $driverConnection);
Expand All @@ -41,7 +42,7 @@ public function testUnserialize()
$this->expectException(\BadMethodCallException::class);
$this->expectExceptionMessage('Cannot unserialize '.PostgreSqlConnection::class);

$driverConnection = $this->createMock(\Doctrine\DBAL\Connection::class);
$driverConnection = $this->createMock(Connection::class);
$driverConnection->method('executeStatement')->willReturn(1);

$connection = new PostgreSqlConnection([], $driverConnection);
Expand All @@ -50,7 +51,7 @@ public function testUnserialize()

public function testListenOnConnection()
{
$driverConnection = $this->createMock(\Doctrine\DBAL\Connection::class);
$driverConnection = $this->createMock(Connection::class);
$driverConnection->method('executeStatement')->willReturn(1);

$driverConnection
Expand Down Expand Up @@ -103,7 +104,7 @@ public function countNotifyCalls()

public function testGetExtraSetupSql()
{
$driverConnection = $this->createMock(\Doctrine\DBAL\Connection::class);
$driverConnection = $this->createMock(Connection::class);
$driverConnection->method('executeStatement')->willReturn(1);
$connection = new PostgreSqlConnection(['table_name' => 'queue_table'], $driverConnection);

Expand All @@ -120,7 +121,7 @@ public function testGetExtraSetupSql()

public function testTransformTableNameWithSchemaToValidProcedureName()
{
$driverConnection = $this->createMock(\Doctrine\DBAL\Connection::class);
$driverConnection = $this->createMock(Connection::class);
$driverConnection->method('executeStatement')->willReturn(1);
$connection = new PostgreSqlConnection(['table_name' => 'schema.queue_table'], $driverConnection);

Expand All @@ -134,7 +135,7 @@ public function testTransformTableNameWithSchemaToValidProcedureName()

public function testGetExtraSetupSqlWrongTable()
{
$driverConnection = $this->createMock(\Doctrine\DBAL\Connection::class);
$driverConnection = $this->createMock(Connection::class);
$driverConnection->method('executeStatement')->willReturn(1);
$connection = new PostgreSqlConnection(['table_name' => 'queue_table'], $driverConnection);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ class ParentDummy
public $rootDummyItems;

/**
* @var \Symfony\Component\PropertyInfo\Tests\Fixtures\RootDummy\RootDummyItem
* @var RootDummyItem
*/
public $rootDummyItem;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
use Symfony\Component\Validator\Mapping\MetadataInterface;

/**
* Returns {@link \Symfony\Component\Validator\Mapping\MetadataInterface} instances for values.
* Returns {@link MetadataInterface} instances for values.
*
* @author Bernhard Schussek <bschussek@gmail.com>
*/
Expand Down
0