8000 [Finder] do not use `assertCount()` with generators by xabbuh · Pull Request #58412 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Finder] do not use assertCount() with generators #58412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2024
Merged

[Finder] do not use assertCount() with generators #58412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
do not use assertCount() with generators 
Generators are no longer supported in PHPUnit 10+.
  • Loading branch information
@xabbuh
xabbuh committed Sep 28, 2024
commit 811967e53014fe9d05e80e4bc2ec607dbed73f50
2 changes: 1 addition & 1 deletion src/Symfony/Component/Finder/Tests/Iterator/LazyIteratorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public function testDelegate()
return new Iterator(['foo', 'bar']);
});

$this->assertCount(2, $iterator);
$this->assertCount(2, iterator_to_array($iterator));
}

public function testInnerDestructedAtTheEnd()
Expand Down
0