8000 [Finder] do not use `assertCount()` with generators by xabbuh · Pull Request #58412 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Finder] do not use assertCount() with generators #58412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2024
Merged

[Finder] do not use assertCount() with generators #58412

merged 1 commit into from
Sep 30, 2024

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Sep 28, 2024
Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

Generators are no longer supported in PHPUnit 10+.

@xabbuh
do not use assertCount() with generators
8000
811967e 
Generators are no longer supported in PHPUnit 10+.
@carsonbot carsonbot added this to the 5.4 milestone Sep 28, 2024
@carsonbot carsonbot changed the title [Finder] do not use assertCount() with generators [Finder] do not use assertCount() with generators Sep 28, 2024
@OskarStark OskarStark changed the title [Finder] do not use assertCount() with generators [Finder] do not use assertCount() with generators Sep 30, 2024
@xabbuh xabbuh merged commit 1832ade into symfony:5.4 Sep 30, 2024
11 of 12 checks passed
@xabbuh xabbuh deleted the phpunit-assert-count-iterator branch September 30, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@derrabus derrabus derrabus approved these changes

@alexandre-daubois alexandre-daubois alexandre-daubois approved these changes

Assignees
No one assigned
Labels
Finder Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@xabbuh @OskarStark @derrabus @alexandre-daubois @carsonbot
0