10000 [Security] Improve translation for `zh_TW` by pan93412 · Pull Request #58138 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Security] Improve translation for zh_TW #58138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2024
Merged

[Security] Improve translation for zh_TW #58138

merged 1 commit into from
Sep 1, 2024

Conversation

pan93412
Copy link
Contributor
@pan93412 pan93412 commented Aug 31, 2024 •
edited
Loading
Q A
Branch? 7.2
Bug fix? no
New feature? no
Deprecations? no
Issues N/A
License MIT
  • Remove unnecessary spaces (ex. before the pronunciations)
  • Replace non-common terms (帳號 instead of 賬號)
  • Improve the translation to be fluent

@pan93412 pan93412 requested a review from chalasr as a code owner August 31, 2024 19:11
@carsonbot carsonbot added this to the 7.2 milestone Aug 31, 2024
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@OskarStark OskarStark changed the title [Security] Improve translation for zh_TW [Security] Improve translation for zh_TW Aug 31, 2024
@pan93412 pan93412 requested a review from lumynou5 September 1, 2024 04:40
Crystal-RainSlide
Crystal-RainSlide approved these changes Sep 1, 2024
View reviewed changes
Copy link
8000
@Crystal-RainSlide Crystal-RainSlide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

lumynou5
lumynou5 approved these changes Sep 1, 2024
View reviewed changes
Copy link
@lumynou5 lumynou5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabpot fabpot changed the base branch from 7.2 to 5.4 September 1, 2024 10:40
@fabpot fabpot changed the base branch from 5.4 to 7.2 8000 September 1, 2024 10:40
@fabpot fabpot modified the milestones: 7.2, 5.4 Sep 1, 2024
@fabpot fabpot changed the base branch from 7.2 to 5.4 September 1, 2024 10:41
@fabpot fabpot force-pushed the security/improve-zh-tw-l10n branch from 2b1c072 to d5131d1 Compare September 1, 2024 10:41
@fabpot
Copy link
Member
fabpot commented Sep 1, 2024

Thank you @pan93412.

@fabpot fabpot merged commit 8b978ff into symfony:5.4 Sep 1, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@Crystal-RainSlide Crystal-RainSlide Crystal-RainSlide approved these changes

@lumynou5 lumynou5 lumynou5 approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@lyrixx lyrixx Awaiting requested review from lyrixx

@yceruto yceruto Awaiting requested review from yceruto

@dunglas dunglas Awaiting requested review from dunglas

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Security Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@pan93412 @carsonbot @fabpot @Crystal-RainSlide @lumynou5
0