8000 [Contracts][HttpClient] Skip tests when zlib's `ob_gzhandler()` doesn't exist by alexandre-daubois · Pull Request #57689 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Contracts][HttpClient] Skip tests when zlib's ob_gzhandler() doesn't exist #57689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2024
Merged

[Contracts][HttpClient] Skip tests when zlib's ob_gzhandler() doesn't exist #57689

merged 1 commit into from
Jul 10, 2024

Conversation

alexandre-daubois
Copy link
Member
Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues -
License MIT

When using a minimal PHP binary without enabling special ext, ob_gzhandler may not be available making a lot of HttpClient's tests fail. The function is used here: https://github.com/symfony/symfony/blob/7.2/src/Symfony/Contracts/HttpClient/Test/Fixtures/web/index.php#L46

@carsonbot carsonbot added this to the 5.4 milestone Jul 9, 2024
@nicolas-grekas
Copy link
Member

Thank you @alexandre-daubois.

@nicolas-grekas nicolas-grekas merged commit b5dba85 into symfony:5.4 Jul 10, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Contracts HttpClient Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandre-daubois @nicolas-grekas @carsonbot
0