minor #57689 [Contracts][HttpClient] Skip tests when zlib's ob_gzhandler() doesn't exist (alexandre-daubois)

nicolas-grekas · nicolas-grekas · commit b5dba855323d · 2024-07-10T10:10:21.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [Contracts][HttpClient] Skip tests when zlib's `ob_gzhandler()` doesn't exist | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT When using a minimal PHP binary without enabling special ext, `ob_gzhandler` may not be available making a lot of HttpClient's tests fail. The function is used here: https://github.com/symfony/symfony/blob/7.2/src/Symfony/Contracts/HttpClient/Test/Fixtures/web/index.php#L46 Commits ------- 97e713b [Contracts][HttpClient] Skip tests when zlib's `ob_gzhandler()` doesn't exist
diff --git a/src/Symfony/Component/HttpClient/Tests/HttplugClientTest.php b/src/Symfony/Component/HttpClient/Tests/HttplugClientTest.php
@@ -37,6 +37,9 @@ public static function tearDownAfterClass(): void
         TestHttpServer::stop();
     }
 
+    /**
+     * @requires function ob_gzhandler
+     */
     public function testSendRequest()
     {
         $client = new HttplugClient(new NativeHttpClient());
@@ -51,6 +54,9 @@ public function testSendRequest()
         $this->assertSame('HTTP/1.1', $body['SERVER_PROTOCOL']);
     }
 
+    /**
+     * @requires function ob_gzhandler
+     */
     public function testSendAsyncRequest()
     {
         $client = new HttplugClient(new NativeHttpClient());
diff --git a/src/Symfony/Component/HttpClient/Tests/Psr18ClientTest.php b/src/Symfony/Component/HttpClient/Tests/Psr18ClientTest.php
@@ -33,6 +33,9 @@ public static function tearDownAfterClass(): void
         TestHttpServer::stop();
     }
 
+    /**
+     * @requires function ob_gzhandler
+     */
     public function testSendRequest()
     {
         $factory = new Psr17Factory();
diff --git a/src/Symfony/Contracts/HttpClient/Test/HttpClientTestCase.php b/src/Symfony/Contracts/HttpClient/Test/HttpClientTestCase.php
@@ -25,6 +25,10 @@ abstract class HttpClientTestCase extends TestCase
 {
     public static function setUpBeforeClass(): void
     {
+        if (!function_exists('ob_gzhandler')) {
+            static::markTestSkipped('The "ob_gzhandler" function is not available.');
+        }
+
         TestHttpServer::start();
     }
 

Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,9 @@ public static function tearDownAfterClass(): void`
`37`	`37`	`TestHttpServer::stop();`
`38`	`38`	`}`
`39`	`39`
	`40`	`+ /**`
	`41`	`+ * @requires function ob_gzhandler`
	`42`	`+ */`
`40`	`43`	`public function testSendRequest()`
`41`	`44`	`{`
`42`	`45`	`$client = new HttplugClient(new NativeHttpClient());`
`@@ -51,6 +54,9 @@ public function testSendRequest()`
`51`	`54`	`$this->assertSame('HTTP/1.1', $body['SERVER_PROTOCOL']);`
`52`	`55`	`}`
`53`	`56`
	`57`	`+ /**`
	`58`	`+ * @requires function ob_gzhandler`
	`59`	`+ */`
`54`	`60`	`public function testSendAsyncRequest()`
`55`	`61`	`{`
`56`	`62`	`$client = new HttplugClient(new NativeHttpClient());`
Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,9 @@ public static function tearDownAfterClass(): void`
`33`	`33`	`TestHttpServer::stop();`
`34`	`34`	`}`
`35`	`35`
	`36`	`+ /**`
	`37`	`+ * @requires function ob_gzhandler`
	`38`	`+ */`
`36`	`39`	`public function testSendRequest()`
`37`	`40`	`{`
`38`	`41`	`$factory = new Psr17Factory();`
Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,10 @@ abstract class HttpClientTestCase extends TestCase`
`25`	`25`	`{`
`26`	`26`	`public static function setUpBeforeClass(): void`
`27`	`27`	`{`
	`28`	`+ if (!function_exists('ob_gzhandler')) {`
	`29`	`+ static::markTestSkipped('The "ob_gzhandler" function is not available.');`
	`30`	`+ }`
	`31`	`+`
`28`	`32`	`TestHttpServer::start();`
`29`	`33`	`}`
`30`	`34`