[Messenger] Double check if pcntl function exists #57514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jun 24, 2024
xabbuh
approved these changes
Jun 24, 2024
|
For 5.4? |
|
Thank you @Toflar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a system where we use the
kernel.terminateevent to triggermessenger:consumein case there's no real worker available. Which means there might be the case that when building the container on cli,pcntl_signal_dispatchexists but in the web process it of course doesn't.Super edge-case but these 3 lines would save me from implementing some logic to unregister this listener myself and I don't see why it would hurt anybody else.