minor #57514 Double check if pcntl function exists (Toflar)

nicolas-grekas · nicolas-grekas · commit 10514a65597b · 2024-06-24T16:43:27.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- Double check if pcntl function exists | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes| New feature? | no | Deprecations? | no | Issues | | License | MIT I have a system where we use the `kernel.terminate` event to trigger `messenger:consume` in case there's no real worker available. Which means there might be the case that when building the container on cli, `pcntl_signal_dispatch` exists but in the web process it of course doesn't. Super edge-case but these 3 lines would save me from implementing some logic to unregister this listener myself and I don't see why it would hurt anybody else. Commits ------- 765eceb Double check if pcntl function exists
diff --git a/src/Symfony/Component/Messenger/EventListener/DispatchPcntlSignalListener.php b/src/Symfony/Component/Messenger/EventListener/DispatchPcntlSignalListener.php
@@ -21,6 +21,10 @@ class DispatchPcntlSignalListener implements EventSubscriberInterface
 {
     public function onWorkerRunning(): void
     {
+        if (!\function_exists('pcntl_signal_dispatch')) {
+            return;
+        }
+
         pcntl_signal_dispatch();
     }
 

Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,10 @@ class DispatchPcntlSignalListener implements EventSubscriberInterface`
`21`	`21`	`{`
`22`	`22`	`public function onWorkerRunning(): void`
`23`	`23`	`{`
	`24`	`+ if (!\function_exists('pcntl_signal_dispatch')) {`
	`25`	`+ return;`
	`26`	`+ }`
	`27`	`+`
`24`	`28`	`pcntl_signal_dispatch();`
`25`	`29`	`}`
`26`	`30`