[Messenger] Catch TableNotFoundException in MySQL delete #54121
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
I suppose 5.4 is also affected? Could you please rebase+retarget for the lowest affected (and maintained) branch? |
|
Thanks @nicolas-grekas - rebased against 5.4 |
| @@ -161,6 +161,10 @@ public function get(): ?array | |||
| $this->driverConnection->delete($this->configuration['table_name'], ['delivered_at' => '9999-12-31 23:59:59']); | |||
| } catch (DriverException $e) { | |||
| // Ignore the exception | |||
| } catch (TableNotFoundException) { | |||
There was a problem hiding this comment.
| } catch (TableNotFoundException) { | |
| } catch (TableNotFoundException $e) { |
|
Thank you @acbramley. |
|
Thanks @fabpot! What's the process of forward-porting this up to 7.1? |
|
We’re merging branches up regularly, so nothing needed on your side. |
When using a MySQL based DB, if the database table doesn't exist when calling Connection::get - it will result in an exception even when auto setup is enabled.
I still need to look into how/where tests would go.