bug #54121 [Messenger] Catch TableNotFoundException in MySQL delete (acbramley)

fabpot · fabpot · commit 56418da03913 · 2024-03-17T15:02:33.000Z
This PR was merged into the 5.4 branch. Discussion ---------- [Messenger] Catch TableNotFoundException in MySQL delete | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #54120 | License | MIT When using a MySQL based DB, if the database table doesn't exist when calling Connection::get - it will result in an exception even when auto setup is enabled. I still need to look into how/where tests would go. Commits ------- 410bcce Catch TableNotFoundException in MySQL delete
diff --git a/src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/Connection.php b/src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/Connection.php
@@ -161,6 +161,10 @@ public function get(): ?array
                 $this->driverConnection->delete($this->configuration['table_name'], ['delivered_at' => '9999-12-31 23:59:59']);
             } catch (DriverException $e) {
                 // Ignore the exception
+            } catch (TableNotFoundException $e) {
+                if ($this->autoSetup) {
+                    $this->setup();
+                }
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -161,6 +161,10 @@ public function get(): ?array`
`161`	`161`	`$this->driverConnection->delete($this->configuration['table_name'], ['delivered_at' => '9999-12-31 23:59:59']);`
`162`	`162`	`} catch (DriverException $e) {`
`163`	`163`	`// Ignore the exception`
	`164`	`+ } catch (TableNotFoundException $e) {`
	`165`	`+ if ($this->autoSetup) {`
	`166`	`+ $this->setup();`
	`167`	`+ }`
`164`	`168`	`}`
`165`	`169`	`}`
`166`	`170`