8000 [Messenger] Revert "Resend failed retries back to failure transport " by ro0NL · Pull Request #54050 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@ro0NL
Copy link
Contributor
@ro0NL ro0NL commented Feb 24, 2024

Reverts #51848

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #...
License MIT

See #53216, it's complex :')

I suggest to get rid of confusion between messenger:consume failed vs. bin/console messenger:failed:retry somehow.

cc @beermeat @guelosuperstart @javaDeveloperKid @fabpot

@fabpot
Copy link
Member
fabpot commented Feb 25, 2024

Thank you @ro0NL.

@fabpot fabpot merged commit 509aa06 into symfony:6.4 Feb 25, 2024
@ro0NL ro0NL deleted the ro0NL-patch-1 branch February 25, 2024 11:02
This was referenced Feb 27, 2024
@alex-dev
Copy link
Contributor
alex-dev commented Apr 2, 2024

While getting rid of the confusion is nice. This still doesn't work well with SQS DLQ. You must use Symfony to handle redrive rather than SQS....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0