bug #54050 [Messenger] Revert "Resend failed retries back to failure transport " (ro0NL)

fabpot · fabpot · commit 509aa067d6b4 · 2024-02-25T08:52:52.000+01:00
This PR was merged into the 6.4 branch. Discussion ---------- [Messenger] Revert "Resend failed retries back to failure transport " Reverts #51848 | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #...  | License | MIT See #53216, it's complex :') I suggest to get rid of confusion between `messenger:consume failed` vs. `bin/console messenger:failed:retry` somehow. cc `@beermeat` `@guelosuperstart` `@javaDeveloperKid` `@fabpot` Commits ------- 8dba632 [Messenger] Revert "Resend failed retries back to failure transport "
diff --git a/src/Symfony/Component/Messenger/EventListener/SendFailedMessageToFailureTransportListener.php b/src/Symfony/Component/Messenger/EventListener/SendFailedMessageToFailureTransportListener.php
@@ -52,6 +52,11 @@ public function onMessageFailed(WorkerMessageFailedEvent $event)
 
         $envelope = $event->getEnvelope();
 
+        // avoid re-sending to the failed sender
+        if (null !== $envelope->last(SentToFailureTransportStamp::class)) {
+            return;
+        }
+
         $envelope = $envelope->with(
             new SentToFailureTransportStamp($event->getReceiverName()),
             new DelayStamp(0),
