8000 [Validator] Consistently use "This value is not" instead of "This is not" in error messages by nicolas-grekas · Pull Request #53420 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Validator] Consistently use "This value is not" instead of "This is not" in error messages #53420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2024
Merged

[Validator] Consistently use "This value is not" instead of "This is not" in error messages #53420

merged 1 commit into from
Jan 9, 2024

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

That's longer but more understandable. That's also how most messages are constructed already.

Related to #53417

@carsonbot carsonbot added this to the 5.4 milestone Jan 4, 2024
@nicolas-grekas nicolas-grekas mentioned this pull request Jan 4, 2024
Merged
@nicolas-grekas nicolas-grekas force-pushed the this-value branch 2 times, most recently from 0e0587a to 1205886 Compare January 4, 2024 15:42
HypeMC
HypeMC reviewed Jan 5, 2024
View reviewed changes
asispts
asispts approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor
@asispts asispts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

state="needs-review-translation" can be removed from Indonesian (id) file.

@nicolas-grekas nicolas-grekas force-pushed the this-value branch 3 times, most recently from 0960b22 to dffe4fe Compare January 5, 2024 11:09
rosier
rosier suggested changes Jan 5, 2024 8000
View reviewed changes
@rosier rosier mentioned this pull request Jan 5, 2024
Closed
@nicolas-grekas nicolas-grekas force-pushed the this-value branch 2 times, most recently from d544484 to 3f4fe1f Compare January 7, 2024 10:46
@nicolas-grekas
Copy link
Member Author

PR rebased

@nicolas-grekas nicolas-grekas mentioned this pull request Jan 8, 2024
Merged
@xabbuh
Copy link
Member
xabbuh commented Jan 9, 2024

@nicolas-grekas After #53444 we now need to update the source of 112 everywhere to "This value is not a valid MAC address.".

@nicolas-grekas
Copy link
Member Author

This value is not a valid MAC address.

updated!

@nicolas-grekas nicolas-grekas merged commit 5f19675 into symfony:5.4 Jan 9, 2024
@nicolas-grekas nicolas-grekas mentioned this pull request Jan 11, 2024
Merged
@nicolas-grekas nicolas-grekas deleted the this-value branch January 11, 2024 12:54
nicolas-grekas added a commit that referenced this pull request Jan 23, 2024
@nicolas-grekas
minor #53507 [Validator] Make it explicit when English translation di…
db2c6e4 
…ffers from its resource name (nicolas-grekas)

This PR was merged into the 5.4 branch.

Discussion
----------

[Validator] Make it explicit when English translation differs from its resource name

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Inspired by #53505
Follows #53420

Commits
-------

eaedae6 [Validator] Make it explicit when English translation differs from its resource name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GromNaN GromNaN GromNaN left review comments

@xabbuh xabbuh xabbuh left review comments

@HypeMC HypeMC HypeMC left review comments

@michaljusiega michaljusiega michaljusiega left review comments

@rosier rosier rosier requested changes

@asispts asispts asispts approved these changes

Assignees
No one assigned
Labels
Status: Needs Review Validator
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
8 participants
@nicolas-grekas @xabbuh @rosier @GromNaN @HypeMC @michaljusiega @asispts @carsonbot
0