8000 [VarExporter] Drop support for partially initialized lazy object by nicolas-grekas · Pull Request #52569 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[VarExporter] Drop support for partially initialized lazy object #52569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2023
Merged

[VarExporter] Drop support for partially initialized lazy object #52569

merged 1 commit into from
Nov 14, 2023

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 7.0
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

Sidekick of #52568

@carsonbot carsonbot added this to the 7.0 milestone Nov 13, 2023
@derrabus
Copy link
Member

⚠️ This PR will break DoctrineBundle which has already been made compatible with Symfony 7.

@nicolas-grekas
Copy link
Member Author

Ah, I forgot about this one. As I wrote on another PR, ORMv3 makes LazyServiceEntityRepository useless, we should deprecate and drop it.

@derrabus
Copy link
Member

ORMv3 makes LazyServiceEntityRepository useless

Yes, but we still need a solution for ORM 2 which will stay around for a while.

we should deprecate and drop it.

LazyServiceEntityRepository is marked as internal, so we can drop that class without deprecation. If we find a way to keep the laziness of ServiceEntityRepository for ORM 2, I'm fine with the late removal of this feature. I won't have time to work on that though. 😕

@nicolas-grekas nicolas-grekas force-pushed the ve-drop-partial branch 2 times, most recently from 3552e79 to 364526d Compare November 14, 2023 12:32
@nicolas-grekas nicolas-grekas merged commit d277959 into symfony:7.0 Nov 14, 2023
@nicolas-grekas nicolas-grekas deleted the ve-drop-partial branch November 14, 2023 12:40
@fabpot fabpot mentioned this pull request Nov 15, 2023
Merged
@back-2-95
Copy link

So how to overcome this? My SF7 project I now need to keep symfony/var-exporter at 7.0.0-BETA1.
Or is there some release coming which would fix this?

@stof
Copy link
Member
stof commented Nov 15, 2023

There is an in-progress PR for DoctrineBundle.

@stof
Copy link
Member
stof commented Nov 15, 2023

Actually, the PR is even merged. So if you use the dev version of DoctrineBundle, it should be OK.

@back-2-95
Copy link

2.11-dev or 2.12-dev ?

@nicolas-grekas
Copy link
Member Author

Here is the PR: doctrine/DoctrineBundle#1727

@stof
Copy link
Member
stof commented Nov 15, 2023

2.11-dev for now. The change has not yet reached 2.12-dev as the merge-up between branches has not yet been done after the merge of that PR.

@back-2-95
Copy link

Ok, I required 2.11-dev for Doctrine Bundle and it worked. Now all my Symfony packages are RC1. Thanks for quick responses.

@derrabus
Copy link
Member

I've released DoctrineBundle 2.11.1 that includes the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review VarExporter
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolas-grekas @derrabus @back-2-95 @stof @carsonbot
0