8000 [VarExporter] Deprecate per-property lazy-initializers by nicolas-grekas · Pull Request #52568 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[VarExporter] Deprecate per-property lazy-initializers #52568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2023
Merged

[VarExporter] Deprecate per-property lazy-initializers #52568

merged 1 commit into from
Nov 14, 2023

Conversation

nicolas-grekas
Copy link
Member
@nicolas-grekas nicolas-grekas commented Nov 13, 2023 •
edited
Loading
Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? yes
Issues -
License MIT

This is a very late deprecation for a complex feature that we'd better drop ASAP IMHO.
Property hooks should be a better solution, even thought it's still WIP.

@carsonbot carsonbot added this to the 6.4 milestone Nov 13, 2023
@nicolas-grekas nicolas-grekas mentioned this pull request Nov 13, 2023
Merged
@stof
Copy link
Member
stof commented Nov 13, 2023

Do you know any place where this feature has been used ?

@nicolas-grekas
Copy link
Member Author

None. That's also why I'm proposing this :)

@derrabus
Copy link
Member

None. That's also why I'm proposing this :)

😬

https://github.com/doctrine/DoctrineBundle/blob/ca64ca70247d7b1b56a57c3b147b77253eaea2f5/Repository/LazyServiceEntityRepository.php#L52-L56

@stof
Copy link
Member
stof commented Nov 13, 2023

Looks like this is actually used...

@nicolas-grekas nicolas-grekas mentioned this pull request Nov 13, 2023
Merged
@nicolas-grekas
Copy link
Member Author

Here the PR to stop relying on this feature: doctrine/DoctrineBundle#1727

@nicolas-grekas nicolas-grekas added the ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" label Nov 13, 2023
@fabpot
Copy link
Member
fabpot commented Nov 14, 2023

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 9b60ff5 into symfony:6.4 Nov 14, 2023
@fabpot fabpot mentioned this pull request Nov 14, 2023
Closed
@nicolas-grekas nicolas-grekas deleted the ve-deprec-partial branch November 14, 2023 08:50
nicolas-grekas added a commit that referenced this pull request Nov 14, 2023
@nicolas-grekas
feature #52569 [VarExporter] Drop support for partially initialized l…
d277959 
…azy object (nicolas-grekas)

This PR was merged into the 7.0 branch.

Discussion
----------

[VarExporter] Drop support for partially initialized lazy object

| Q             | A
| ------------- | ---
| Branch?       | 7.0
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Sidekick of #52568

Commits
-------

27650ef [VarExporter] Drop support for partially initialized lazy object
This was referenced Nov 15, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
< 6108 div class="discussion-sidebar-heading text-bold"> Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Deprecation ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" Status: Reviewed VarExporter
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolas-grekas @stof @derrabus @fabpot @carsonbot
0