10000 UriResolver support path with columns by vdauchy · Pull Request #52558 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

UriResolver support path with columns #52558

New issue

Have a questio 8000 n about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Symfony/Component/DomCrawler/Tests/UriResolverTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,10 @@ public static function provideResolverTests()

['foo', 'http://localhost?bar=1', 'http://localhost/foo'],
['foo', 'http://localhost#bar', 'http://localhost/foo'],

['foo:1', 'http://localhost', 'http://localhost/foo:1'],
['/bar:1', 'http://localhost', 'http://localhost/bar:1'],
['foo/bar:1', 'http://localhost', 'http://localhost/foo/bar:1'],
];
}
}
2 changes: 1 addition & 1 deletion src/Symfony/Component/DomCrawler/UriResolver.php
42AA
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public static function resolve(string $uri, ?string $baseUri): string
$uri = trim($uri);

// absolute URL?
if (null !== parse_url($uri, \PHP_URL_SCHEME)) {
if (is_string(parse_url($uri, \PHP_URL_SCHEME))) {
return $uri;
}

Expand Down
0