8000 UriResolver support path with columns by vdauchy · Pull Request #52558 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

UriResolver support path with columns #52558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service 8000 and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

UriResolver support path with columns #52558

wants to merge 1 commit into from

Conversation

vdauchy
Copy link
Contributor
@vdauchy vdauchy commented Nov 12, 2023 •
edited
Loading
Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix UriResolver bad handling of column in path
License MIT

Resolving links on pages using weird pagination like: https://localhost/domain/search/page:5 fails due to : making

var_dump(parse_url('/page:1', \PHP_URL_SCHEME));

Return false (and not null as expected in the code).

This simply ensure the absolute URL is returned only if the SCHEME is found (ie a string is returned by parse_url).

@carsonbot carsonbot added this to the 6.4 milestone Nov 12, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.3".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@vdauchy
Copy link
Contributor Author
vdauchy commented Nov 12, 2023

Re-openned on branch 6.3: #52559

@vdauchy vdauchy closed this Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Review
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
2 participants
@vdauchy @carsonbot
0