8000 [AssetMapper] Improving exception if a vendor asset's path is not mapped by weaverryan · Pull Request #52521 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[AssetMapper] Improving exception if a vendor asset's path is not mapped #52521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2023
Merged

[AssetMapper] Improving exception if a vendor asset's path is not mapped #52521

merged 1 commit into from
Nov 10, 2023

Conversation

weaverryan
Copy link
Member
Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #52513
License MIT
Screenshot 2023-11-09 at 1 33 49 PM

It's a bit long - but this should be a RARE error, when users are messing around with asset mapper paths. So giving them more info is better.

/cc @evertharmeling :)

@carsonbot carsonbot added this to the 6.4 milestone Nov 9, 2023
@evertharmeling
Copy link
Contributor

That's great! Thanks for the fast response!

And for the record, I wasn't 'messing around' 😅

@weaverryan
Copy link
Member Author

And for the record, I wasn't 'messing around' 😅

Ha! Fair. You were doing the "completely normal use-cases... except that Ryan never considered them before" :). For most projects, I'm assuming users will never care or touch the asset mapper paths, but we'll see.

nicolas-grekas
nicolas-grekas reviewed Nov 9, 2023
View reviewed changes
@weaverryan weaverryan force-pushed the asset-mapper-better-missing-vendor-exception branch from 8d01a61 to 4d66462 Compare November 10, 2023 02:27
@fabpot fabpot merged commit 18d866c into symfony:6.4 Nov 10, 2023
@weaverryan weaverryan deleted the asset-mapper-better-missing-vendor-exception branch November 11, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

Assignees
No one assigned
Labels
AssetMapper Feature Status: Needs Review
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

[AssetMapper] Adding the assets/vendor path by default to framework.asset_mapper.paths
5 participants
@weaverryan @evertharmeling @nicolas-grekas @fabpot @carsonbot
0