[AssetMapper] Improving exception if a vendor asset's path is not mapped

weaverryan · weaverryan · commit 8d01a6164ac9 · 2023-11-09T13:34:10.000-05:00
diff --git a/src/Symfony/Component/AssetMapper/ImportMap/ImportMapGenerator.php b/src/Symfony/Component/AssetMapper/ImportMap/ImportMapGenerator.php
@@ -232,7 +232,11 @@ private function findEagerImports(MappedAsset $asset): array
     private function createMissingImportMapAssetException(ImportMapEntry $entry): \InvalidArgumentException
     {
         if ($entry->isRemotePackage()) {
-            throw new LogicException(sprintf('The "%s" vendor asset is missing. Try running the "importmap:install" command.', $entry->importName));
+            if (!file_exists($entry->path)) {
+                throw new LogicException(sprintf('The "%s" vendor asset is missing. Try running the "importmap:install" command.', $entry->importName));
+            }
+
+            throw new LogicException(sprintf('The "%s" vendor file exists locally (%s), but cannot be found in any asset map paths. Be sure the assets vendor directory is an asset mapper path.', $entry->importName, $entry->path));
         }
 
         throw new LogicException(sprintf('The asset "%s" cannot be found in any asset map paths.', $entry->path));

Original file line number	Diff line number	Diff line change
`@@ -232,7 +232,11 @@ private function findEagerImports(MappedAsset $asset): array`
`232`	`232`	`private function createMissingImportMapAssetException(ImportMapEntry $entry): \InvalidArgumentException`
`233`	`233`	`{`
`234`	`234`	`if ($entry->isRemotePackage()) {`
`235`		`- throw new LogicException(sprintf('The "%s" vendor asset is missing. Try running the "importmap:install" command.', $entry->importName));`
	`235`	`+ if (!file_exists($entry->path)) {`
	`236`	`+ throw new LogicException(sprintf('The "%s" vendor asset is missing. Try running the "importmap:install" command.', $entry->importName));`
	`237`	`+ }`
	`238`	`+`
	`239`	`+ throw new LogicException(sprintf('The "%s" vendor file exists locally (%s), but cannot be found in any asset map paths. Be sure the assets vendor directory is an asset mapper path.', $entry->importName, $entry->path));`
`236`	`240`	`}`
`237`	`241`
`238`	`242`	`throw new LogicException(sprintf('The asset "%s" cannot be found in any asset map paths.', $entry->path));`