8000 [Translation] Add argument `$buildDir` to `DataCollectorTranslator::warmUp()` by nicolas-grekas · Pull Request #52140 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Translation] Add argument $buildDir to DataCollectorTranslator::warmUp() #52140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT

Reverting part of #52136 to keep cross-versions compatibility of components.

We already did so a few times where the risk of breaking BC for real-life apps was considered low. It think this qualifies.

@carsonbot carsonbot added this to the 6.4 milestone Oct 18, 2023
@carsonbot carsonbot changed the title [Translator] Add argument $buildDir to DataCollectorTranslator::warmUp() [Translation] Add argument $buildDir to DataCollectorTranslator::warmUp() Oct 18, 2023
@nicolas-grekas nicolas-grekas merged commit 1a72bd5 into symfony:6.4 Oct 18, 2023
@nicolas-grekas nicolas-grekas deleted the tr-bc branch October 18, 2023 12:23
This was referenced Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0