8000 do not allow version 7 of the HttpKernel component by xabbuh · Pull Request #52136 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

do not allow version 7 of the HttpKernel component #52136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2023
Merged

do not allow version 7 of the HttpKernel component #52136

merged 1 commit into from
Oct 18, 2023

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Oct 18, 2023
Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT

@carsonbot carsonbot added this to the 6.4 milestone Oct 18, 2023
@xabbuh xabbuh merged commit 4b3ad55 into symfony:6.4 Oct 18, 2023
@xabbuh xabbuh deleted the pr-50391 branch October 18, 2023 11:20
@nicolas-grekas nicolas-grekas mentioned this pull request Oct 18, 2023
Merged
nicolas-grekas added a commit that referenced this pull request Oct 18, 2023
@nicolas-grekas
feature #52140 [Translation] Add argument $buildDir to `DataCollect…
1a72bd5 
…orTranslator::warmUp()` (nicolas-grekas)

This PR was merged into the 6.4 branch.

Discussion
----------

[Translation] Add argument `$buildDir` to `DataCollectorTranslator::warmUp()`

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | -
| License       | MIT

Reverting part of #52136 to keep cross-versions compatibility of components.

We already did so a few times where the risk of breaking BC for real-life apps was considered low. It think this qualifies.

Commits
-------

d18bd27 [Translator] Add argument `$buildDir` to `DataCollectorTranslator::warmUp()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

@welcoMattic welcoMattic Awaiting requested review from welcoMattic welcoMattic is a code owner

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @derrabus @carsonbot
0