8000 [AssetMapper] Link needs as="style" by weaverryan · Pull Request #52108 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[AssetMapper] Link needs as="style" #52108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

weaverryan
Copy link
Member
Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Mentioned on symfony/recipes#1245 (comment)
License MIT

Hi!

The as="style" is required. It was missing from the docs (I'll make a PR there) and so I forgot it :). Tested on a real project to verify the warning was gone.

Cheers!

@nicolas-grekas
Copy link
Member

Thank you @weaverryan.

@nicolas-grekas nicolas-grekas merged commit b9122bc into symfony:6.4 Oct 17, 2023
@weaverryan weaverryan deleted the asset-mapper-preload-as-attribute branch October 17, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0