bug #52108 [AssetMapper] Link needs as="style" (weaverryan)

nicolas-grekas · nicolas-grekas · commit b9122bcfb7ab · 2023-10-17T14:54:19.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [AssetMapper] Link needs as="style" | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Mentioned on symfony/recipes#1245 (comment) | License | MIT Hi! The `as="style"` is required. It was missing from the docs (I'll make a PR there) and so I forgot it :). Tested on a real project to verify the warning was gone. Cheers! Commits ------- 6c55206 [AssetMapper] Link needs as="style"
diff --git a/src/Symfony/Component/AssetMapper/ImportMap/ImportMapRenderer.php b/src/Symfony/Component/AssetMapper/ImportMap/ImportMapRenderer.php
@@ -163,7 +163,7 @@ private function createAttributesString(array $attributes): string
 
     private function addWebLinkPreloads(Request $request, array $cssLinks): void
     {
-        $cssPreloadLinks = array_map(fn ($url) => new Link('preload', $url), $cssLinks);
+        $cssPreloadLinks = array_map(fn ($url) => (new Link('preload', $url))->withAttribute('as', 'style'), $cssLinks);
 
         if (null === $linkProvider = $request->attributes->get('_links')) {
             $request->attributes->set('_links', new GenericLinkProvider($cssPreloadLinks));
diff --git a/src/Symfony/Component/AssetMapper/Tests/ImportMap/ImportMapRendererTest.php b/src/Symfony/Component/AssetMapper/Tests/ImportMap/ImportMapRendererTest.php
@@ -195,6 +195,7 @@ public function testItAddsPreloadLinks()
         $this->assertInstanceOf(GenericLinkProvider::class, $linkProvider);
         $this->assertCount(1, $linkProvider->getLinks());
         $this->assertSame(['preload'], $linkProvider->getLinks()[0]->getRels());
+        $this->assertSame(['as' => 'style'], $linkProvider->getLinks()[0]->getAttributes());
         $this->assertSame('/assets/styles/app-preload-d1g35t.css', $linkProvider->getLinks()[0]->getHref());
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,7 @@ private function createAttributesString(array $attributes): string`
`163`	`163`
`164`	`164`	`private function addWebLinkPreloads(Request $request, array $cssLinks): void`
`165`	`165`	`{`
`166`		`- $cssPreloadLinks = array_map(fn ($url) => new Link('preload', $url), $cssLinks);`
	`166`	`+ $cssPreloadLinks = array_map(fn ($url) => (new Link('preload', $url))->withAttribute('as', 'style'), $cssLinks);`
`167`	`167`
`168`	`168`	`if (null === $linkProvider = $request->attributes->get('_links')) {`
`169`	`169`	`$request->attributes->set('_links', new GenericLinkProvider($cssPreloadLinks));`
Original file line number	Diff line number	Diff line change
`@@ -195,6 +195,7 @@ public function testItAddsPreloadLinks()`
`195`	`195`	`$this->assertInstanceOf(GenericLinkProvider::class, $linkProvider);`
`196`	`196`	`$this->assertCount(1, $linkProvider->getLinks());`
`197`	`197`	`$this->assertSame(['preload'], $linkProvider->getLinks()[0]->getRels());`
	`198`	`+ $this->assertSame(['as' => 'style'], $linkProvider->getLinks()[0]->getAttributes());`
`198`	`199`	`$this->assertSame('/assets/styles/app-preload-d1g35t.css', $linkProvider->getLinks()[0]->getHref());`
`199`	`200`	`}`
`200`	`201`	`}`