8000 [PhpUnitBridge] Add keyword `dev` to leverage composer hint by OskarStark · Pull Request #51925 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[PhpUnitBridge] Add keyword dev to leverage composer hint #51925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2023
Merged

[PhpUnitBridge] Add keyword dev to leverage composer hint #51925

merged 1 commit into from
Oct 10, 2023

Conversation

OskarStark
Copy link
Contributor
Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT

@OskarStark OskarStark self-assigned this Oct 10, 2023
@carsonbot carsonbot added this to the 5.4 milestone Oct 10, 2023
@OskarStark OskarStark requested a review from stof October 10, 2023 06:20
@carsonbot carsonbot changed the title Add keyword dev to leverage composer hint [PhpUnitBridge] Add keyword dev to leverage composer hint Oct 10, 2023
@fabpot
Copy link
Member
fabpot commented Oct 10, 2023

Thank you @OskarStark.

@fabpot fabpot merged commit 00adb85 into symfony:5.4 Oct 10, 2023
norkunas
norkunas reviewed Oct 10, 2023
View reviewed changes
src/Symfony/Bridge/PhpUnit/composer.json
@@ -2,7 +2,7 @@
"name": "symfony/phpunit-bridge",
"type": "symfony-bridge",
"description": "Provides utilities for PHPUnit, especially user deprecation notices management",
"keywords": [],
"keywords": ['dev'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are single quotes valid json?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but @fabpot fixed it while merging in e86d26a

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet :)
I fixed it just after the merge when I realized that ;)

@OskarStark OskarStark deleted the dev2 branch October 10, 2023 10:23
@jderusse jderusse mentioned this pull request Oct 12, 2023
Merged
nicolas-grekas added a commit that referenced this pull request Oct 12, 2023
@nicolas-grekas
minor #52010 Revert "dev" keyword on PhpUnitBridge (jderusse)
991dd0d 
This PR was merged into the 5.4 branch.

Discussion
----------

Revert "dev" keyword on PhpUnitBridge

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | /
| License       | MIT

This PR revert #51925

The issue with the `dev` key word, is: Composer ask to re-run command with the `--dev` flag

Which makes `simple-phpunit` stuck when running in a CI

For the recall:
- simple-phpunit run `composer require --no-update symfony/phpunit-bridge "*`@dev`"` https://github.com/symfony/symfony/blob/5f77c3fb3e5b95b577b1fd17cb03c12be568c70d/src/Symfony/Bridge/PhpUnit/bin/simple-phpunit.php#L256
- composer ask for re-running the command in `--dev`
https://github.com/composer/composer/blob/c827c93b62186488dbffdf4b614413ae7a785607/src/Composer/Command/RequireCommand.php#L235-L261

Commits
-------

315a8a4 Revert "Add keyword `dev` to leverage composer hint"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@norkunas norkunas norkunas left review comments

@stof stof Awaiting requested review from stof

Assignees

@OskarStark OskarStark

Labels
PhpUnitBridge Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@OskarStark @fabpot @norkunas @carsonbot
0