Added: Tests for Mac constraint

Fixed: Test for `Ip` constraint
symfony · Ninos · Sep 28, 2023 · Sep 28, 2023 · Sep 28, 2023 · Sep 28, 2023
commit 2200cd82911e63b513b6781d871fa8613d08f66f
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/IpTest.php b/src/Symfony/Component/Validator/Tests/Constraints/IpTest.php
@@ -50,7 +50,7 @@ public function testAttributes()
         self::assertTrue($loader->loadClassMetadata($metadata));
 
         [$aConstraint] = $metadata->properties['a']->getConstraints();
-        self::assertSame(Ip::V4, $aConstraint->version);
+        self::assertSame(Ip::ALL, $aConstraint->version);
 
         [$bConstraint] = $metadata->properties['b']->getConstraints();
         self::assertSame(Ip::V6, $bConstraint->version);

diff --git a/src/Symfony/Component/Validator/Tests/Constraints/IpValidatorTest.php b/src/Symfony/Component/Validator/Tests/Constraints/IpValidatorTest.php
@@ -95,7 +95,7 @@ public function testValidIpV6WithWhitespacesNamed()
     {
         $this->validator->validate(
             "\n\t2001:0db8:85a3:0000:0000:8a2e:0370:7334\r\n",
-            new Ip(version: \Symfony\Component\Validator\Constraints\Ip::V6, normalizer: 'trim')
+            new Ip(version: Ip::V6, normalizer: 'trim')
         );
 
         $this->assertNoViolation();

diff --git a/src/Symfony/Component/Validator/Tests/Constraints/MacTest.php b/src/Symfony/Component/Validator/Tests/Constraints/MacTest.php
@@ -0,0 +1,70 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\Validator\Tests\Constraints;
+
+use PHPUnit\Framework\TestCase;
+use Symfony\Component\Validator\Constraints\Mac;
+use Symfony\Component\Validator\Exception\InvalidArgumentException;
+use Symfony\Component\Validator\Mapping\ClassMetadata;
+use Symfony\Component\Validator\Mapping\Loader\AttributeLoader;
+
+/**
+ * @author Ninos Ego <me@ninosego.de>
+ */
+class MacTest extends TestCase
+{
+    public function testNormalizerCanBeSet()
+    {
+        $ip = new Mac(['normalizer' => 'trim']);
+
+        $this->assertEquals('trim', $ip->normalizer);
+    }
+
+    public function testInvalidNormalizerThrowsException()
+    {
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('The "normalizer" option must be a valid callable ("string" given).');
+        new Mac(['normalizer' => 'Unknown Callable']);
+    }
+
+    public function testInvalidNormalizerObjectThrowsException()
+    {
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('The "normalizer" option must be a valid callable ("stdClass" given).');
+        new Mac(['normalizer' => new \stdClass()]);
+    }
+
+    public function testAttributes()
+    {
+        $metadata = new ClassMetadata(IpDummy::class);
+        $loader = new AttributeLoader();
+        self::assertTrue($loader->loadClassMetadata($metadata));
+
+        [$aConstraint] = $metadata->properties['a']->getConstraints();
+        self::assertSame('myMessage', $aConstraint->message);
+        self::assertSame('trim', $aConstraint->normalizer);
+        self::assertSame(['Default', 'IpDummy'], $aConstraint->groups);
+
+        [$bConstraint] = $metadata->properties['b']->getConstraints();
+        self::assertSame(['my_group'], $bConstraint->groups);
+        self::assertSame('some attached data', $bConstraint->payload);
+    }
+}
+
+class MacDummy
+{
+    #[Mac( message: 'myMessage', normalizer: 'trim')]
+    private $a;
+
+    #[Mac(groups: ['my_group'], payload: 'some attached data')]
+    private $b;
+}
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/MacValidatorTest.php b/src/Symfony/Component/Validator/Tests/Constraints/MacValidatorTest.php
@@ -0,0 +1,125 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\Validator\Tests\Constraints;
+
+use Symfony\Component\Validator\Constraints\Mac;
+use Symfony\Component\Validator\Constraints\MacValidator;
+use Symfony\Component\Validator\Exception\UnexpectedValueException;
+use Symfony\Component\Validator\Test\ConstraintValidatorTestCase;
+
+/**
+ * @author Ninos Ego <me@ninosego.de>
+ */
+class MacValidatorTest extends ConstraintValidatorTestCase
+{
+    protected function createValidator(): MacValidator
+    {
+        return new MacValidator();
+    }
+
+    public function testNullIsValid()
+    {
+        $this->validator->validate(null, new Mac());
+
+        $this->assertNoViolation();
+    }
+
+    public function testEmptyStringIsValid()
+    {
+        $this->validator->validate('', new Mac());
+
+        $this->assertNoViolation();
+    }
+
+    public function testExpectsStringCompatibleType()
+    {
+        $this->expectException(UnexpectedValueException::class);
+        $this->validator->validate(new \stdClass(), new Mac());
+    }
+
+    /**
+     * @dataProvider getValidMacs
+     */
+    public function testValidMac($mac)
+    {
+        $this->validator->validate($mac, new Mac());
+
+        $this->assertNoViolation();
+    }
+
+    public static function getValidMacs()
+    {
+        return [
+            ['00:00:00:00:00:00'],
+            ['00-00-00-00-00-00'],
+            ['ff:ff:ff:ff:ff:ff'],
+            ['ff-ff-ff-ff-ff-ff'],
+            ['FF:FF:FF:FF:FF:FF'],
+            ['FF-FF-FF-FF-FF-FF'],
+        ];
+    }
+
+    /**
+     * @dataProvider getValidMacsWithWhitespaces
+     */
+    public function testValidMacsWithWhitespaces($mac)
+    {
+        $this->validator->validate($mac, new Mac([
+            'normalizer' => 'trim',
+        ]));
+
+        $this->assertNoViolation();
+    }
+
+    public static function getValidMacsWithWhitespaces()
+    {
+        return [
+            ["\x2000:00:00:00:00:00"],
+            ["\x09\x0900-00-00-00-00-00"],
+            ["ff:ff:ff:ff:ff:ff\x0A"],
+            ["ff-ff-ff-ff-ff-ff\x0D\x0D"],
+            ["\x00FF:FF:FF:FF:FF:FF\x00"],
+            ["\x0B\x0BFF-FF-FF-FF-FF-FF\x0B\x0B"],
+        ];
+    }
+
+    /**
+     * @dataProvider getInvalidMacs
+     */
+    public function testInvalidMacs($mac)
+    {
+        $constraint = new Mac([
+            'message' => 'myMessage',
+        ]);
+
+        $this->validator->validate($mac, $constraint);
+
+        $this->buildViolation('myMessage')
+            ->setParameter('{{ value }}', '"'.$mac.'"')
+            ->setCode(Mac::INVALID_MAC_ERROR)
+            ->assertRaised();
+    }
+
+    public static function getInvalidMacs()
+    {
+        return [
+            ['0'],
+            ['00:00'],
+            ['00:00:00'],
+            ['00:00:00:00'],
+            ['00:00:00:00:00'],
+            ['00:00:00:00:00:000'],
+            ['-00:00:00:00:00:00'],
+            ['foobar'],
+        ];
+    }
+}