Enhancement: OnlyPrivate & OnlyReserved tests

symfony · Ninos · Sep 28, 2023 · Sep 28, 2023 · Sep 28, 2023 · Sep 28, 2023
commit c11c261a96c7d47e816647708a444764624778b3
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/IpValidatorTest.php b/src/Symfony/Component/Validator/Tests/Constraints/IpValidatorTest.php
@@ -185,6 +185,15 @@ public function testInvalidIpsV4($ip)
             ->assertRaised();
     }
 
+    public static function getValidPublicIpsV4()
+    {
+        return [
+            ['8.0.0.0'],
+            ['90.0.0.0'],
+            ['110.0.0.110'],
+        ];
+    }
+
     public static function getInvalidIpsV4()
     {
         return [
@@ -231,7 +240,7 @@ public function testInvalidPrivateIpsV4($ip)
     }
 
     /**
-     * @dataProvider getValidReservedIpsV4
+     * @dataProvider getInvalidPrivateIpsV4
      */
     public function testInvalidOnlyPrivateIpsV4($ip)
     {
@@ -257,6 +266,11 @@ public static function getValidPrivateIpsV4()
         ];
     }
 
+    public static function getInvalidPrivateIpsV4()
+    {
+        return array_merge(self::getValidPublicIpsV4(), self::getValidReservedIpsV4());
+    }
+
     /**
      * @dataProvider getValidReservedIpsV4
      */
@@ -288,7 +302,7 @@ public function testInvalidReservedIpsV4($ip)
     }
 
     /**
-     * @dataProvider getValidPrivateIpsV4
+     * @dataProvider getInvalidReservedIpsV4
      */
     public function testInvalidOnlyReservedIpsV4($ip)
     {
@@ -314,6 +328,11 @@ public static function getValidReservedIpsV4()
         ];
     }
 
+    public static function getInvalidReservedIpsV4()
+    {
+        return array_merge(self::getValidPublicIpsV4(), self::getValidPrivateIpsV4());
+    }
+
     /**
      * @dataProvider getInvalidPublicIpsV4
      */