8000 [PropertyInfo] Remove checking if `AttributeMetadataInterface::setIgnore` method exists by alamirault · Pull Request #51607 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[PropertyInfo] Remove checking if AttributeMetadataInterface::setIgnore method exists #51607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2023
Merged

[PropertyInfo] Remove checking if AttributeMetadataInterface::setIgnore method exists #51607

merged 1 commit into from
Sep 10, 2023

Conversation

alamirault
Copy link
Contributor
Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

This PR remove checking if method AttributeMetadataInterface::setIgnore exists.

This method was introduced in symfony 5.1 (https://github.com/symfony/symfony/pull/28744/files#diff-98f3aa4632c5366a34f92bfa1b2165742bf5b572da2fb4f888d8fe47465eb8eaR67), so with the following requirements, it's always available

  • PropertyInfo: conflict with "symfony/serializer": "<5.4",

@alamirault alamirault requested a review from dunglas as a code owner September 9, 2023 14:36
@carsonbot carsonbot added this to the 6.4 milestone Sep 9, 2023
@alamirault alamirault changed the title [PropertyInfo] Remove checking if AttributeMetadataInterface setIgnore method exists [PropertyInfo] Remove checking if AttributeMetadataInterface::setIgnore method exists Sep 9, 2023
dunglas
dunglas approved these changes Sep 9, 2023
View reviewed changes
Copy link
Member
@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could even remove the variable.

@fabpot
Copy link
< 9ABF /details>
Member
fabpot commented Sep 10, 2023

Thank you @alamirault.

@fabpot fabpot merged commit 0ac0229 into symfony:6.4 Sep 10, 2023
@alamirault alamirault deleted the feature/remove-method-exists-AttributeMetadataInterface-setIgnore branch September 20, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@dunglas dunglas dunglas approved these changes

Assignees
No one assigned
Labels
PropertyInfo Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@alamirault @fabpot @dunglas @carsonbot
0