minor #51607 [PropertyInfo] Remove checking if AttributeMetadataInterface::setIgnore method exists (alamirault)

fabpot · fabpot · commit 0ac0229d138d · 2023-09-10T10:33:22.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [PropertyInfo] Remove checking if `AttributeMetadataInterface::setIgnore` method exists | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no  | Deprecations? | no  | Tickets | Fix #...  | License | MIT | Doc PR | symfony/symfony-docs#...  This PR remove checking if method `AttributeMetadataInterface::setIgnore` exists. This method was introduced in symfony 5.1 (https://github.com/symfony/symfony/pull/28744/files#diff-98f3aa4632c5366a34f92bfa1b2165742bf5b572da2fb4f888d8fe47465eb8eaR67), so with the following requirements, it's always available - PropertyInfo: conflict with `"symfony/serializer": "<5.4",` Commits ------- e2237cd [PropertyInfo] Remove checking if AttributeMetadataInterface setIgnore method exist
diff --git a/src/Symfony/Component/PropertyInfo/Extractor/SerializerExtractor.php b/src/Symfony/Component/PropertyInfo/Extractor/SerializerExtractor.php
@@ -42,7 +42,7 @@ public function getProperties(string $class, array $context = []): ?array
         $serializerClassMetadata = $this->classMetadataFactory->getMetadataFor($class);
 
         foreach ($serializerClassMetadata->getAttributesMetadata() as $serializerAttributeMetadata) {
-            $ignored = method_exists($serializerAttributeMetadata, 'isIgnored') && $serializerAttributeMetadata->isIgnored();
+            $ignored = $serializerAttributeMetadata->isIgnored();
             if (!$ignored && (null === $context['serializer_groups'] || array_intersect($context['serializer_groups'], $serializerAttributeMetadata->getGroups()))) {
                 $properties[] = $serializerAttributeMetadata->getName();
             }

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ public function getProperties(string $class, array $context = []): ?array`
`42`	`42`	`$serializerClassMetadata = $this->classMetadataFactory->getMetadataFor($class);`
`43`	`43`
`44`	`44`	`foreach ($serializerClassMetadata->getAttributesMetadata() as $serializerAttributeMetadata) {`
`45`		`- $ignored = method_exists($serializerAttributeMetadata, 'isIgnored') && $serializerAttributeMetadata->isIgnored();`
	`45`	`+ $ignored = $serializerAttributeMetadata->isIgnored();`
`46`	`46`	`if (!$ignored && (null === $context['serializer_groups'] \|\| array_intersect($context['serializer_groups'], $serializerAttributeMetadata->getGroups()))) {`
`47`	`47`	`$properties[] = $serializerAttributeMetadata->getName();`
`48`	`48`	`}`