8000 [FrameworkBundle][Routing] Deprecate annotations by alexandre-daubois · Pull Request #51483 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle][Routing] Deprecate annotations #51483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2023
Merged

[FrameworkBundle][Routing] Deprecate annotations #51483

merged 1 commit into from
Oct 17, 2023

Conversation

@alexandre-daubois
Copy link
Member
@alexandre-daubois alexandre-daubois commented Aug 25, 2023 •
edited
Loading
Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? yes
Tickets Part of #51381
License MIT
Doc PR -
  • Deprecate the routing.loader.annotation service, use the routing.loader.attribute service instead
  • Deprecate the routing.loader.annotation.directory service, use the routing.loader.attribute.directory service instead
  • Deprecate the routing.loader.annotation.file service, use the routing.loader.attribute.file service instead
  • Deprecate AnnotationClassLoader, use AttributeClassLoader instead
  • Deprecate AnnotationDirectoryLoader, use AttributeDirectoryLoader instead
  • Deprecate AnnotationFileLoader, use AttributeFileLoader instead
  • Deprecate AnnotatedRouteControllerLoader, use AttributeRouteControllerLoader

@carsonbot carsonbot added this to the 6.4 milestone Aug 25, 2023
@alexandre-daubois alexandre-daubois mentioned this pull request Aug 25, 2023
Closed
7 tasks
@alexandre-daubois alexandre-daubois force-pushed the router-annotation-loader-deprec branch 2 times, most recently from 9f4fd1d to 8f9bdda Compare August 25, 2023 11:19
@alexandre-daubois alexandre-daubois force-pushed the router-annotation-loader-deprec branch from 8f9bdda to e0426c9 Compare August 25, 2023 11:48
@alexandre-daubois alexandre-daubois force-pushed the router-annotation-loader-deprec branch from e0426c9 to da057c7 Compare October 2, 2023 08:16
@alexandre-daubois
Copy link
Member Author
alexandre-daubois commented Oct 2, 2023

Rebased and conflicts fixed

@nicolas-grekas nicolas-grekas added the ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" label Oct 6, 2023
chalasr
chalasr requested changes Oct 6, 2023
View reviewed changes
@alexandre-daubois alexandre-daubois force-pushed the router-annotation-loader-deprec branch 3 times, most recently from c476880 to 0ea026e Compare October 9, 2023 07:23
fancyweb
fancyweb reviewed Oct 13, 2023
View reviewed changes
fancyweb
fancyweb reviewed Oct 13, 2023
View reviewed changes
fancyweb
fancyweb reviewed Oct 13, 2023
View reviewed changes
fancyweb
fancyweb reviewed Oct 13, 2023
View reviewed changes
@fancyweb
Copy link
Contributor
fancyweb commented Oct 13, 2023

Instead of the current strategy, what about copy-pasting the existing Annotation classes code in the new Attribute classes, and then make existing Annotation classes extends those new Attribute classes.

@alexandre-daubois alexandre-daubois force-pushed the router-annotation-loader-deprec branch from 0ea026e to b559652 Compare October 15, 2023 10:36
@alexandre-daubois
Copy link
Member Author
alexandre-daubois commented Oct 15, 2023

@fancyweb I think that the current way of doing is better for upmerges. It will be easier for potential fixes if the annotation classes remain the same. Otherwise, all fixes in Annotation*Loader will have to be manually reflected in Attribute*Loader when merging to upper branches

@alexandre-daubois alexandre-daubois force-pushed the 8000 router-annotation-loader-deprec branch 4 times, most recently from 9b778bf to 94c5354 Compare October 15, 2023 11:02
nicolas-grekas
nicolas-grekas reviewed Oct 15, 2023
View reviewed changes
@alexandre-daubois alexandre-daubois force-pushed the router-annotation-loader-deprec branch 10 times, most recently from 85d87ae to e51fe86 Compare October 17, 2023 11:46
@nicolas-grekas nicolas-grekas force-pushed the router-annotation-loader-deprec branch from e51fe86 to 708b1b6 Compare October 17, 2023 13:59
nicolas-grekas
nicolas-grekas approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class_alias trick is the best!

8000
@nicolas-grekas
Copy link
Member
nicolas-grekas commented Oct 17, 2023

Thank you @alexandre-daubois.

@nicolas-grekas nicolas-grekas merged commit 1469612 into symfony:6.4 Oct 17, 2023
@nicolas-grekas nicolas-grekas mentioned this pull request Oct 17, 2023
Closed
@alexandre-daubois
Copy link
Member Author
alexandre-daubois commented Oct 17, 2023

I'll work on the cleanup 🙂

@alexandre-daubois alexandre-daubois mentioned this pull request Oct 18, 2023
Merged
@alexandre-daubois alexandre-daubois deleted the router-annotation-loader-deprec branch October 18, 2023 11:03
nicolas-grekas added a commit that referenced this pull request Oct 18, 2023
@nicolas-grekas
minor #52137 [FrameworkBundle][Routing] Remove remaining deprecations…
950cd70 
… (alexandre-daubois)

This PR was merged into the 7.0 branch.

Discussion
----------

[FrameworkBundle][Routing] Remove remaining deprecations

| Q             | A
| ------------- | ---
| Branch?       | 7.0
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT

Follows #51483, I took `Annotation*Loader` from 7.0 to update `Attribute*Loader` here with latest changes.

Commits
-------

77f6efc [FrameworkBundle][Routing] Remove remaining deprecations
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull request Oct 18, 2023
@nicolas-grekas
minor #52137 [FrameworkBundle][Routing] Remove remaining deprecations…
fe9b172 
… (alexandre-daubois)

This PR was merged into the 7.0 branch.

Discussion
----------

[FrameworkBundle][Routing] Remove remaining deprecations

| Q             | A
| ------------- | ---
| Branch?       | 7.0
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT

Follows symfony/symfony#51483, I took `Annotation*Loader` from 7.0 to update `Attribute*Loader` here with latest changes.

Commits
-------

77f6efc601 [FrameworkBundle][Routing] Remove remaining deprecations
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derrabus derrabus derrabus left review comments

@chalasr chalasr chalasr requested changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

+1 more reviewer

@fancyweb fancyweb fancyweb left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Deprecation FrameworkBundle Routing ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" Status: Reviewed

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

6 participants

@alexandre-daubois @fancyweb @nicolas-grekas @derrabus @chalasr @carsonbot
0