[FrameworkBundle][Routing] Remove remaining deprecations #52137
Conversation
c5a289f to
4076990
Compare
4076990 to
4c79047
Compare
4c79047 to
77f6efc
Compare
|
Thank you @alexandre-daubois. |
| */ | ||
| protected function configureRoute(Route $route, \ReflectionClass $class, \ReflectionMethod $method, object $annot) | ||
| protected function configureRoute(Route $route, \ReflectionClass $class, \ReflectionMethod $method, object $annot): void |
There was a problem hiding this comment.
This makes SymfonyBundle 6.4 incompatible with SymfonyRouter 7.0
PHP Fatal error: Declaration of Symfony\Bundle\FrameworkBundle\Routing\AttributeRouteControllerLoader::configureRoute(Symfony\Component\Routing\Route $route, ReflectionClass $class, ReflectionMethod $method, object $annot) must be compatible with Symfony\Component\Routing\Loader\AttributeClassLoader::configureRoute(Symfony\Component\Routing\Route $route, ReflectionClass $class, ReflectionMethod $method, object $annot): void in /home/runner/work/aws/aws/vendor/symfony/framework-bundle/Routing/AttributeRouteControllerLoader.php on line 31
There was a problem hiding this comment.
What's the best way to mitigate this? Return types were added nearly everywhere but all constraints have been kept to ^6.4|^7.0.
Should this return type be removed until the next occasion we can add it?
There was a problem hiding this comment.
I see 2 options:
- make Bundle require
^7.0 - adds
: voidinBundle:7.0and inRoute:8.0
I think the first is better.
ping @nicolas-grekas
There was a problem hiding this comment.
I'm going to remove the added return type in 7.0. That's what we did with the previous name, but I forgot this part when renaming.
Follows #51483, I took
Annotation*Loaderfrom 7.0 to updateAttribute*Loaderhere with latest changes.