[FrameworkBundle] Remove config deprecations #51428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
added a commit
that referenced
this pull request
Aug 21, 2023
…session.save_path` and `framework.session.handler_id` at the same time (alexandre-daubois) This PR was merged into the 6.4 branch. Discussion ---------- [FrameworkBundle] Deprecate not setting both `framework.session.save_path` and `framework.session.handler_id` at the same time | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | yes | Tickets | - | License | MIT | Doc PR | - This is the follow-up of #51428 (comment) Commits ------- 85faa69 [FrameworkBundle] Deprecate not setting both `framework.session.save_path` and `framework.session.handler_id` at the same time
GromNaN
reviewed
Aug 21, 2023
e98b2db to
9a05727
Compare
| $v['session'] += [ | ||
| 'cookie_samesite' => null, | ||
| 'handler_id' => 'session.handler.native_file', | ||
| 'save_path' => '%kernel.cache_dir%/sessions', |
There was a problem hiding this comment.
when handler_id is non-null, save_path should still default to %kernel.cache_dir%/sessions, how can we deal with that?
There was a problem hiding this comment.
I updated the condition:
if (!\array_key_exists('handler_id', $v['session'])) {
$v['session']['handler_id'] = $v['session']['save_path'] ? 'session.handler.native_file' : null;
} elseif (null !== $v['session']['handler_id']) {
$v['session']['save_path'] ??= '%kernel.cache_dir%/sessions';
}Also updated changelog to Make the framework.session.save_path config option default to %kernel.cache_dir%/sessions if framework.session.handler_id is set or null otherwise
There was a problem hiding this comment.
I also added a call to info() to document this behavior
cfaee6f to
0106c5b
Compare
0106c5b to
7935e94
Compare
7935e94 to
45cdb7c
Compare
|
I'd say this PR should be merged before this one to fix the errors raised by I fixed the |
5ce5bac to
d9c64ff
Compare
d9c64ff to
4fe6f5b
Compare
|
Thank you @alexandre-daubois. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of: