8000 [AssetMapper] Add command to download missing downloaded packages by jmsche · Pull Request #51351 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[AssetMapper] Add command to download missing downloaded packages #51351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2023
Merged

[AssetMapper] Add command to download missing downloaded packages #51351

merged 1 commit into from
Aug 23, 2023

Conversation

jmsche
Copy link
Contributor
@jmsche jmsche commented Aug 11, 2023
Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets N/A
License MIT
Doc PR None yet

Hi, this PR adds a importmap:install command to download all packages marked as downloaded in the impormap.php file that are missing on filesystem.

To quote @weaverryan:

the intention is to allow devs to not commit assets/vendor/, which means that this is a command you’ll run during deploy and your teammates will run

@carsonbot carsonbot added this to the 6.4 milestone Aug 11, 2023
@jmsche
Copy link
Contributor Author
jmsche commented Aug 11, 2023

AppVeyor failure unrelated.
I guess Unit Tests 8.2 fail because this branch is not merged in 7.0 yet 😄
Not sure about Psalm, I think it's okay.

@weaverryan weaverryan mentioned this pull request Aug 15, 2023
Merged
@jmsche
Copy link
Contributor Author
jmsche commented Aug 16, 2023

Updated PR with rewording, thrown exception is no version found & added a test :)

@nicolas-grekas nicolas-grekas force-pushed the asset-mapper-download-missing branch from 989e725 to a82a429 Compare August 23, 2023 20:08
@nicolas-grekas
Copy link
Member

Thank you @jmsche.

@nicolas-grekas nicolas-grekas merged commit c24906f into symfony:6.4 Aug 23, 2023
@jmsche jmsche deleted the asset-mapper-download-missing branch August 24, 2023 07:10
This was referenced Aug 24, 2023
Merged
Merged
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Aug 28, 2023
@javiereguiluz
minor #18785 [AssetMapper] Add docs for importmap:install command (…
2990dbe 
…jmsche)

This PR was merged into the 6.4 branch.

Discussion
----------

[AssetMapper] Add docs for `importmap:install` command

Hi, this PR adds docs for the new `importmap:install` command added by symfony/symfony#51351.

Commits
-------

978f1dc [AssetMapper] Add docs for the importmap:install command
fabpot added a commit that referenced this pull request Aug 30, 2023
@fabpot
minor #51471 [AssetMapper] Improve message when a downloaded asset is…
420a5d2 
… not found (jmsche)

This PR was merged into the 6.4 branch.

Discussion
----------

[AssetMapper] Improve message when a downloaded asset is not found

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

This PR improves the exception message introduced in #51337 by mentioning the command introduced in #51351.

Commits
-------

69cae6f [AssetMapper] Improve exception message when a downloaded asset is not found
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@dunglas dunglas dunglas approved these changes

@weaverryan weaverryan weaverryan approved these changes

Assignees
No one assigned
Labels
AssetMapper Feature Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
5 participants
@jmsche @nicolas-grekas @dunglas @weaverryan @carsonbot
0