minor #51471 [AssetMapper] Improve message when a downloaded asset is not found (jmsche)

fabpot · fabpot · commit 420a5d27902f · 2023-08-30T08:34:41.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [AssetMapper] Improve message when a downloaded asset is not found | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A This PR improves the exception message introduced in #51337 by mentioning the command introduced in #51351. Commits ------- 69cae6f [AssetMapper] Improve exception message when a downloaded asset is not found
diff --git a/src/Symfony/Component/AssetMapper/ImportMap/ImportMapManager.php b/src/Symfony/Component/AssetMapper/ImportMap/ImportMapManager.php
@@ -412,7 +412,7 @@ private function convertEntriesToImports(array $entries): array
             if (null !== $entryOptions->path) {
                 if (!$asset = $this->assetMapper->getAsset($entryOptions->path)) {
                     if ($entryOptions->isDownloaded) {
-                        throw new \InvalidArgumentException(sprintf('The "%s" downloaded asset is missing. Run "php bin/console importmap:require "%s" --download".', $entryOptions->path, $entryOptions->importName));
+                        throw new \InvalidArgumentException(sprintf('The "%s" downloaded asset is missing. Run "php bin/console importmap:install".', $entryOptions->path));
                     }
 
                     throw new \InvalidArgumentException(sprintf('The asset "%s" mentioned in "%s" cannot be found in any asset map paths.', $entryOptions->path, basename($this->importMapConfigPath)));

Original file line number	Diff line number	Diff line change
`@@ -412,7 +412,7 @@ private function convertEntriesToImports(array $entries): array`
`412`	`412`	`if (null !== $entryOptions->path) {`
`413`	`413`	`if (!$asset = $this->assetMapper->getAsset($entryOptions->path)) {`
`414`	`414`	`if ($entryOptions->isDownloaded) {`
`415`		`- throw new \InvalidArgumentException(sprintf('The "%s" downloaded asset is missing. Run "php bin/console importmap:require "%s" --download".', $entryOptions->path, $entryOptions->importName));`
	`415`	`+ throw new \InvalidArgumentException(sprintf('The "%s" downloaded asset is missing. Run "php bin/console importmap:install".', $entryOptions->path));`
`416`	`416`	`}`
`417`	`417`
`418`	`418`	`throw new \InvalidArgumentException(sprintf('The asset "%s" mentioned in "%s" cannot be found in any asset map paths.', $entryOptions->path, basename($this->importMapConfigPath)));`