8000 [Notifier] [AmazonSns] README update by OskarStark · Pull Request #51226 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Notifier] [AmazonSns] README update #51226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

OskarStark
Copy link
Contributor
Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Follows #51216
License MIT
Doc PR

Applied @stof comments from

@OskarStark OskarStark requested a review from stof August 2, 2023 09:28
@OskarStark OskarStark self-assigned this Aug 2, 2023
@carsonbot carsonbot added this to the 5.4 milestone Aug 2, 2023
@carsonbot carsonbot changed the title [Notifier][AmazonSns] README update [Notifier] [AmazonSns] README update Aug 2, 2023
- `PROFILE` is the name of your AWS configured profile (optional, default: `default`)

You can find more information in the official AWS documentation:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the documentation of thePHP sdk used unedrhood, not the general AWS doc

@nicolas-grekas
Copy link
Member

Thank you @OskarStark.

@nicolas-grekas nicolas-grekas merged commit b39fcef into symfony:5.4 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0