[Notifier] Document Amazon Notifier options #51216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Aug 2, 2023
|
Thank you Antoine. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 2, 2023
…irault) This PR was merged into the 6.4 branch. Discussion ---------- [Notifier] Document Amazon Notifier SSLMODE option | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Merge after #51216 Document Amazon Notifier SSLMODE option This PR fix symfony/symfony-docs#18652 Commits ------- 17f606b [Notifier] Document Amazon Notifier SSLMODE option
stof
reviewed
Aug 2, 2023
| where: | ||
| - `ACCESS_ID` is your AWS access key id | ||
| - `ACCESS_KEY` is your AWS access key secret | ||
| - `REGION` is the AWS region targeted (optional, default: `us-east-1`) |
There was a problem hiding this comment.
Suggested change
| - `REGION` is the AWS region targeted (optional, default: `us-east-1`) | |
| - `REGION` is the targeted AWS region (optional, default: `us-east-1`) |
| - `ACCESS_ID` is your AWS access key id | ||
| - `ACCESS_KEY` is your AWS access key secret | ||
| - `REGION` is the AWS region targeted (optional, default: `us-east-1`) | ||
| - `PROFILE` is the name of your AWS configured profile (optional, default: `default`) |
There was a problem hiding this comment.
maybe this should link to the async-aws documentation to explain what this is about.
|
@stof I opened a PR with your comments, sorry for being too fast 🌷 |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 2, 2023
This PR was merged into the 5.4 branch. Discussion ---------- [Notifier] [AmazonSns] README update | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Follows #51216 | License | MIT | Doc PR | Applied `@stof` comments from * #51216 Commits ------- 269eb10 [Notifier][AmazonSns] README update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation of notifier options are in their own README
This PR prepare symfony/symfony-docs#18652 in branch 5.4
Wording is taken from https://async-aws.com/configuration.html