8000 [Routing] Remove Doctrine annotations support by derrabus · Pull Request #51082 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Routing] Remove Doctrine annotations support #51082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2023
Merged

[Routing] Remove Doctrine annotations support #51082

merged 1 commit into from
Jul 26, 2023

Conversation

derrabus
Copy link
Member
Q A
Branch? 7.0
Bug fix? no
New feature? yes
Deprecations? no
Tickets Follows #49358
License MIT
Doc PR symfony/symfony-docs#18589

@carsonbot carsonbot added this to the 7.0 milestone Jul 24, 2023
@derrabus derrabus force-pushed the remove/routing-annotations branch 3 times, most recently from 987823d to 0114d73 Comp 8000 are July 24, 2023 12:27
@derrabus derrabus mentioned this pull request Jul 24, 2023
Merged
nicolas-grekas added a commit that referenced this pull request Jul 24, 2023
@nicolas-grekas
minor #51084 [Routing] Fix testMissingPrefixLocale and `testMissing…
8b82019 
…RouteLocale` (derrabus)

This PR was merged into the 5.4 branch.

Discussion
----------

[Routing] Fix `testMissingPrefixLocale` and `testMissingRouteLocale`

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #51082 (comment)
| License       | MIT
| Doc PR        | not needed

Those two fixtures only exist as annotation versions. Their attribute counterparts were missing.

The corresponding tests only expected a `LogicException` which is what `AnnotationClassLoader` would raise for undefined classes as well.

This PR adds new assertions for the exception messages which would have discovered the missing fixtures. Finally, the two missing fixtures are added.

Commits
-------

6ba9864 [Routing] Fix testMissingPrefixLocale and testMissingRouteLocale
@derrabus derrabus force-pushed the remove/routing-annotations branch from 0114d73 to 9a27bae Compare July 24, 2023 14:06
@derrabus derrabus force-pushed the remove/routing-annotations branch from 9a27bae to 4b10902 Compare July 24, 2023 21:22
@derrabus derrabus requested a review from nicolas-grekas July 24, 2023 22:06
@fabpot
Copy link
Member
fabpot commented Jul 26, 2023

Thank you @derrabus.

@fabpot fabpot merged commit 07b0bb8 into symfony:7.0 Jul 26, 2023
@derrabus derrabus deleted the remove/routing-annotations branch July 26, 2023 05:51
@derrabus derrabus mentioned this pull request Jul 27, 2023
Closed
@fabpot fabpot mentioned this pull request Oct 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Feature Routing Status: Reviewed
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@derrabus @fabpot @nicolas-grekas @carsonbot
0