8000 [FrameworkBundle] Deprecate doctrine/annotations integration · Issue #18589 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] Deprecate doctrine/annotations integration #18589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolas-grekas opened this issue Jul 20, 2023 · 5 comments
Closed

[FrameworkBundle] Deprecate doctrine/annotations integration #18589

nicolas-grekas opened this issue Jul 20, 2023 · 5 comments 8000
Labels
FrameworkBundle hasPR A Pull Request has already been submitted for this issue.
Milestone
6.4

Comments

@nicolas-grekas
Copy link
Member
Q A
Feature PR symfony/symfony#50888
PR author(s) @derrabus
Merged in 6.4

We created this issue to not forget to document this new feature. We would really appreciate if you can help us with this task. If you are not sure how to do it, please ask us and we will help you.

To fix this issue, please create a PR against the 6.4 branch in the symfony-docs repository.

Thank you! 😃
@nicolas-grekas nicolas-grekas added this to the 6.4 milestone Jul 20, 2023
@alexandre-daubois
Copy link
Member

What's the prefered way to go here?

  • Should we simply remove php-annotations code blocks and annotation occurrences in 7.0?
  • Should we add a deprecation message somewhere in 6.4 ? Like next to each php-annotations block ?

I can take care of what will be decided 🙂

@javiereguiluz
Copy link
Member

Let's ask @wouterj and @xabbuh because they always have good ideas about how to handle deprecations like this one. Thanks.

@wouterj
Copy link
Member
wouterj commented Jul 20, 2023

My first thought would be to simply remove all php-annotations blocks in 6.4 already and only leave the annotations docs where we explicitly talk about them (but as far as I see, we most often only talk about attributes in 6.4 already) + add a deprecation directive in only these places.

@xabbuh
Copy link
Member
xabbuh commented Jul 20, 2023

I also had the same thought. Adding a deprecation notice to all annotation examples would probably be too much of work.

@alexandre-daubois alexandre-daubois mentioned this issue Jul 20, 2023
Merged
This was referenced Jul 20, 2023
Merged
Merged
Merged
Merged
javiereguiluz added a commit that referenced this issue Jul 21, 2023
@javiereguiluz
minor #18590 [Documentation] Deprecate annotations (alexandre-daubois)
b4683ae 
This PR was merged into the 6.4 branch.

Discussion
----------

[Documentation] Deprecate annotations

My take on #18589, feedbacks always welcome! 🙂

Commits
-------

0380429 [Documentation] Deprecate annotations
@javiereguiluz
Copy link
Member

Closing as fixed in #18590

@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Jul 21, 2023
nicolas-grekas added a commit to symfony/symfony that referenced this issue Jul 24, 2023
@nicolas-grekas
feature #51050 [FrameworkBundle] Remove doctrine/annotations integrat…
e377224 
…ion (derrabus)

This PR was merged into the 7.0 branch.

Discussion
----------

[FrameworkBundle] Remove doctrine/annotations integration

| Q             | A
| ------------- | ---
| Branch?       | 7.0
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Follows #50888
| License       | MIT
| Doc PR        | TODO, see symfony/symfony-docs#18589

Commits
-------

713ff44 [FrameworkBundle] Remove doctrine/annotations integration
nicolas-grekas added a commit to symfony/symfony that referenced this issue Jul 24, 2023
@nicolas-grekas
feature #50983 [Serializer] Deprecate annotations in favor of attribu…
f6c7a74 
…tes (derrabus)

This PR was merged into the 6.4 branch.

Discussion
----------

[Serializer] Deprecate annotations in favor of attributes

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | yes
| Tickets       | Follows #50888
| License       | MIT
| Doc PR        | TODO, see symfony/symfony-docs#18589

This PR deprecates using Doctrine annotations to configure serialization. Attributes shall be used instead.

Existing applications can be migrated easily using [Rector](https://getrector.com/blog/how-to-upgrade-annotations-to-attributes).

Deprecation errors triggered by the bundles' functional tests will be resolved once #50888 is merged.

Commits
-------

9b7b397 [Serializer] Deprecate annotations in favor of attributes
symfony-splitter pushed a commit to symfony/serializer that referenced this issue Jul 24, 2023
@nicolas-grekas
feature #50983 [Serializer] Deprecate annotations in favor of attribu…
4ead537 
…tes (derrabus)

This PR was merged into the 6.4 branch.

Discussion
----------

[Serializer] Deprecate annotations in favor of attributes

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | yes
| Tickets       | Follows #50888
| License       | MIT
| Doc PR        | TODO, see symfony/symfony-docs#18589

This PR deprecates using Doctrine annotations to configure serialization. Attributes shall be used instead.

Existing applications can be migrated easily using [Rector](https://getrector.com/blog/how-to-upgrade-annotations-to-attributes).

Deprecation errors triggered by the bundles' functional tests will be resolved once symfony/symfony#50888 is merged.

Commits
-------

9b7b397ec4 [Serializer] Deprecate annotations in favor of attributes
nicolas-grekas added a commit to symfony/symfony that referenced this issue Jul 24, 2023
@nicolas-grekas
feature #50982 [Validator] Deprecate annotations in favor of attribut…
8e36ac6 
…es (derrabus)

This PR was merged into the 6.4 branch.

Discussion
----------

[Validator] Deprecate annotations in favor of attributes

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | yes
| Tickets       | Follows #50888
| License       | MIT
| Doc PR        | TODO, see symfony/symfony-docs#18589

This PR deprecates using Doctrine annotations to configure validation constraints. Attributes shall be used instead.

Existing applications can be migrated easily using [Rector](https://getrector.com/blog/how-to-upgrade-annotations-to-attributes).

Deprecation errors triggered by the bundles' functional tests will be resolved once #50888 is merged.

Commits
-------

6b6dc62 [Validator] Deprecate annotations in favor of attributes
@derrabus derrabus mentioned this issue Jul 24, 2023
Merged
nicolas-grekas added a commit to symfony/symfony that referenced this issue Jul 24, 2023
@nicolas-grekas
feature #49358 [Routing] Deprecate annotations in favor of attributes…
32d4dfa 
… (derrabus)

This PR was merged into the 6.4 branch.

Discussion
----------

[Routing] Deprecate annotations in favor of attributes

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | yes
| Tickets       | Follows #50888
| License       | MIT
| Doc PR        | TODO, see symfony/symfony-docs#18589

This PR deprecates the integration of Doctrine Annotations for the Routing component.

Attributes are the way to go now if we want to annotate controllers with routing information. Existing applications can be migrated easily using [Rector](https://getrector.com/blog/how-to-upgrade-annotations-to-attributes).

Thus I believe that keeping support for oldschool Doctrine Annotations is not necessary anymore.

If this PR is accepted, I would work on a follow-up that renames all `Annotation*Loader` classes because the names of those classes are probably misleading as soon as they support attributes only.

Commits
-------

6ce15f2 [Routing] Deprecate annotations in favor of attributes
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this issue Jul 24, 2023
@nicolas-grekas
feature #49358 [Routing] Deprecate annotations in favor of attributes…
3ea34f7 
… (derrabus)

This PR was merged into the 6.4 branch.

Discussion
----------

[Routing] Deprecate annotations in favor of attributes

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | yes
| Tickets       | Follows #50888
| License       | MIT
| Doc PR        | TODO, see symfony/symfony-docs#18589

This PR deprecates the integration of Doctrine Annotations for the Routing component.

Attributes are the way to go now if we want to annotate controllers with routing information. Existing applications can be migrated easily using [Rector](https://getrector.com/blog/how-to-upgrade-annotations-to-attributes).

Thus I believe that keeping support for oldschool Doctrine Annotations is not necessary anymore.

If this PR is accepted, I would work on a follow-up that renames all `Annotation*Loader` classes because the names of those classes are probably misleading as soon as they support attributes only.

Commits
-------

6ce15f22b1 [Routing] Deprecate annotations in favor of attributes
nicolas-grekas added a commit to symfony/symfony that referenced this issue Jul 24, 2023
@nicolas-grekas
feature #51080 [Serializer] Remove Doctrine annotations support (derr…
297cc32 
…abus)

This PR was merged into the 7.0 branch.

Discussion
----------

[Serializer] Remove Doctrine annotations support

| Q             | A
| ------------- | ---
| Branch?       | 7.0
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Follows #50983
| License       | MI
8000
T
| Doc PR        | symfony/symfony-docs#18589

Commits
-------

67013e2 [Serializer] Remove Doctrine annotations support
This was referenced Jul 24, 2023
Merged
Merged
nicolas-grekas added a commit to symfony/symfony that referenced this issue Jul 24, 2023
@nicolas-grekas
feature #51085 [Validator] Remove Doctrine annotations support (derra…
ffe6f08 
…bus)

This PR was merged into the 7.0 branch.

Discussion
----------

[Validator] Remove Doctrine annotations support

| Q             | A
| ------------- | ---
| Branch?       | 7.0
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Follows #50982
| License       | MIT
| Doc PR        | symfony/symfony-docs#18589

Commits
-------

d18dfa5 [Validator] Remove Doctrine annotations support
fabpot added a commit to symfony/symfony that referenced this issue Jul 26, 2023
@fabpot
feature #51082 [Routing] Remove Doctrine annotations support (derrabus)
07b0bb8 
This PR was merged into the 7.0 branch.

Discussion
----------

[Routing] Remove Doctrine annotations support

| Q             | A
| ------------- | ---
| Branch?       | 7.0
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Follows #49358
| License       | MIT
| Doc PR        | symfony/symfony-docs#18589

Commits
-------

4b10902 [Routing] Remove Doctrine annotations support
symfony-splitter pushed a commit to symfony/routing that referenced this issue Jul 26, 2023
@fabpot
feature #51082 [Routing] Remove Doctrine annotations support (derrabus)
73615d3 
This PR was merged into the 7.0 branch.

Discussion
----------

[Routing] Remove Doctrine annotations support

| Q             | A
| ------------- | ---
| Branch?       | 7.0
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Follows #49358
| License       | MIT
| Doc PR        | symfony/symfony-docs#18589

Commits
-------

4b109020d0 [Routing] Remove Doctrine annotations support
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this issue Jul 28, 2023
@nicolas-grekas
feature #49358 [Routing] Deprecate annotations in favor of attributes…
c1e3cbb 
… (derrabus)

This PR was merged into the 6.4 branch.

Discussion
----------

[Routing] Deprecate annotations in favor of attributes

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | yes
| Tickets       | Follows #50888
| License       | MIT
| Doc PR        | TODO, see symfony/symfony-docs#18589

This PR deprecates the integration of Doctrine Annotations for the Routing component.

Attributes are the way to go now if we want to annotate controllers with routing information. Existing applications can be migrated easily using [Rector](https://getrector.com/blog/how-to-upgrade-annotations-to-attributes).

Thus I believe that keeping support for oldschool Doctrine Annotations is not necessary anymore.

If this PR is accepted, I would work on a follow-up that renames all `Annotation*Loader` classes because the names of those classes are probably misleading as soon as they support attributes only.

Commits
-------

6ce15f22b1 [Routing] Deprecate annotations in favor of attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FrameworkBundle hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
6.4
Development

No branches or pull requests
6 participants
@javiereguiluz @nicolas-grekas @wouterj @xabbuh @alexandre-daubois @carsonbot
0