8000 [FrameworkBundle] Remove doctrine/annotations integration by derrabus · Pull Request #51050 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] Remove doctrine/annotations integration #51050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and priv 8000 acy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2023
Merged

[FrameworkBundle] Remove doctrine/annotations integration #51050

merged 1 commit into from
Jul 24, 2023

Conversation

derrabus
Copy link
Member
Q A
Branch? 7.0
Bug fix? no
New feature? yes
Deprecations? no
Tickets Follows #50888
License MIT
Doc PR TODO, see symfony/symfony-docs#18589

@carsonbot carsonbot added this to the 7.0 milestone Jul 20, 2023
@derrabus derrabus force-pushed the remove/annotations-integration branch from 44b8b76 to cbf8a2e Compare July 20, 2023 17:27
nicolas-grekas
nicolas-grekas reviewed Jul 21, 2023
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please mind fabbot :)

@derrabus derrabus force-pushed the remove/annotations-integration branch from cbf8a2e to 713ff44 Compare July 22, 2023 23:43
Seb33300
Seb33300 reviewed Jul 23, 2023
View reviewed changes
UPGRADE-7.0.md
@@ -121,6 +121,8 @@ FrameworkBundle
$this->render(..., ['form' => $form]);
```

* Remove the integration of Doctrine annotations, use native attributes instead
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not supposed to be removed in Symfony 8?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #50888, you said:

The plan is to make this the default and only valid option in Symfony 7 and remove that setting entirely in Symfony 8.

Copy link
Contributor
@Seb33300 Seb33300 Jul 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh sorry, just got it. The option cannot be enabled on Symfony 7

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the setting is still there. You just cannot enable it.

@nicolas-grekas
Copy link
Member

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit e377224 into symfony:7.0 Jul 24, 2023
@derrabus derrabus deleted the remove/annotations-integration branch July 24, 2023 06:33
@derrabus derrabus mentioned this pull request Jul 27, 2023
Closed
@fabpot fabpot mentioned this pull request Oct 21, 2023
Merged
@jderusse jderusse mentioned this pull request Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@Seb33300 Seb33300 Seb33300 left review comments

Assignees
No one assigned
Labels
Feature FrameworkBundle Status: Needs Review
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@derrabus @nicolas-grekas @Seb33300 @carsonbot
0