[Serializer] Handle type error constructing input #51003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+430
to
+447
| if (preg_match('/#\d+ \(\$([^)]+)\) must be of type ([^,]+), ([^,]+) given/', $message, $match)) { | ||
| $message = sprintf( | ||
| 'The type of the "%s" parameter for class "%s" must be of type "%s" ("%s" given).', | ||
| $match[1], | ||
| $class, | ||
| $match[2], | ||
| $match[3], | ||
| ); | ||
| } | ||
|
|
||
| $exception = NotNormalizableValueException::createForUnexpectedDataType( | ||
| $message, | ||
| $data, | ||
| [$class], | ||
| $context['deserialization_path'] ?? null, | ||
| true, | ||
| previous: $e, | ||
| ); |
There was a problem hiding this comment.
Perhaps it would be better this way
Suggested change
| if (preg_match('/#\d+ \(\$([^)]+)\) must be of type ([^,]+), ([^,]+) given/', $message, $match)) { | |
| $message = sprintf( | |
| 'The type of the "%s" parameter for class "%s" must be of type "%s" ("%s" given).', | |
| $match[1], | |
| $class, | |
| $match[2], | |
| $match[3], | |
| ); | |
| } | |
| $exception = NotNormalizableValueException::createForUnexpectedDataType( | |
| $message, | |
| $data, | |
| [$class], | |
| $context['deserialization_path'] ?? null, | |
| true, | |
| previous: $e, | |
| ); | |
| $type = $class; | |
| if (preg_match('/#\d+ \(\$([^)]+)\) must be of type ([^,]+), ([^,]+) given/', $message, $match)) { | |
| $message = sprintf( | |
| 'The type of the "%s" parameter for class "%s" must be of type "%s" ("%s" given).', | |
| $match[1], | |
| $class, | |
| $match[2], | |
| $match[3], | |
| ); | |
| $type = $match[2]; | |
| } | |
| $exception = NotNormalizableValueException::createForUnexpectedDataType( | |
| $message, | |
| $data, | |
| [$type], | |
| $context['deserialization_path'] ?? null, | |
| true, | |
| previous: $e, | |
| ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When mapping a input to an object, for instance with:
And
MyInputhas an hard-type:Then you try to call this route with invalid type:
/api/endpoint?id[]=abcThe construction of
MyInputwill fail with aTypeErrorMyInput::__construct(): Argument #1 ($id) must be of type ?string, array given.But this is caught in
AbstractNormalizerthen you get a 500 error (unhandled)Typed property MyInput::id must not be accessed before initialization.With this PR, I propose to handle it instead as a 400 error (bad request)
The type of the "id" parameter for class "MyInput" must be of type "?string" ("array" given).